chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/permissions/permissions_api_helpers.cc ('k') | chrome/browser/extensions/api/preference/preference_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

diff --git a/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc b/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

index 4bf9a449fef0b8949181b76a80767daeb71ca695..f033ad19aeca01d4e3bbe416f32a82bcfa43a47c 100644

--- a/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

+++ b/chrome/browser/extensions/api/preference/chrome_direct_setting_api.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/extensions/api/preference/chrome_direct_setting_api.h"

+#include <utility>

#include "base/bind.h"

#include "base/containers/hash_tables.h"

#include "base/lazy_instance.h"

@@ -158,8 +160,8 @@ void ChromeDirectSettingAPI::OnPrefChanged(

events::HistogramValue histogram_value =

events::TYPES_PRIVATE_CHROME_DIRECT_SETTING_ON_CHANGE;

scoped_ptr<Event> event(

- new Event(histogram_value, event_name, args_copy.Pass()));

- router->DispatchEventToExtension(extension_id, event.Pass());

+ new Event(histogram_value, event_name, std::move(args_copy)));

+ router->DispatchEventToExtension(extension_id, std::move(event));

}