Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Unified Diff: chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
diff --git a/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc b/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
index 6264141b77e907712209301602467139a2e8473c..481852800f6121fae41ab082ffe898683e685df9 100644
--- a/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
+++ b/chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc
@@ -191,11 +191,12 @@ TEST_F(ExtensionInfoGeneratorUnitTest, BasicInfoTest) {
.Build();
scoped_ptr<base::DictionaryValue> manifest_copy(manifest->DeepCopy());
scoped_refptr<const Extension> extension =
- ExtensionBuilder().SetManifest(manifest.Pass())
- .SetLocation(Manifest::UNPACKED)
- .SetPath(data_dir())
- .SetID(id)
- .Build();
+ ExtensionBuilder()
+ .SetManifest(std::move(manifest))
+ .SetLocation(Manifest::UNPACKED)
+ .SetPath(data_dir())
+ .SetID(id)
+ .Build();
service()->AddExtension(extension.get());
ErrorConsole* error_console = ErrorConsole::Get(profile());
error_console->ReportError(
@@ -271,10 +272,11 @@ TEST_F(ExtensionInfoGeneratorUnitTest, BasicInfoTest) {
manifest_copy->SetString("update_url",
"https://clients2.google.com/service/update2/crx");
id = crx_file::id_util::GenerateId("beta");
- extension = ExtensionBuilder().SetManifest(manifest_copy.Pass())
- .SetLocation(Manifest::EXTERNAL_PREF)
- .SetID(id)
- .Build();
+ extension = ExtensionBuilder()
+ .SetManifest(std::move(manifest_copy))
+ .SetLocation(Manifest::EXTERNAL_PREF)
+ .SetID(id)
+ .Build();
service()->AddExtension(extension.get());
info = GenerateExtensionInfo(extension->id());
EXPECT_EQ(developer::LOCATION_THIRD_PARTY, info->location);

Powered by Google App Engine
This is Rietveld 408576698