chrome/browser/extensions/api/developer_private/extension_info_generator.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/extension_info_generator.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/extension_info_generator.cc

diff --git a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc b/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

index dd2d583ce873a16f8575ab79f273c0f85dd1dff8..858e9b8eee5e76a1fc4656053a217b3eefb5b56a 100644

--- a/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

+++ b/chrome/browser/extensions/api/developer_private/extension_info_generator.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/extensions/api/developer_private/extension_info_generator.h"

+#include <utility>

#include "base/base64.h"

#include "base/location.h"

#include "base/single_thread_task_runner.h"

@@ -546,12 +548,9 @@ void ExtensionInfoGenerator::CreateExtensionInfoHelper(

// used by the url is 48x48).

gfx::Size max_size(128, 128);

image_loader_->LoadImageAsync(

- &extension,

- icon,

- max_size,

+ &extension, icon, max_size,

base::Bind(&ExtensionInfoGenerator::OnImageLoaded,

- weak_factory_.GetWeakPtr(),

- base::Passed(info.Pass())));

+ weak_factory_.GetWeakPtr(), base::Passed(std::move(info))));

}