chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.cc - Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.cc

Issue 1549233002: Convert Pass()→std::move() in //chrome/browser/extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/extension_info_generator_unittest.cc ('k') | chrome/browser/extensions/api/dial/dial_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.cc

diff --git a/chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.cc b/chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.cc

index c38ee8102286e37448c8588167c8e06c8ad05f14..d791ed1937685e110e6a89ca349f3d5af5261358 100644

--- a/chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.cc

+++ b/chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/extensions/api/developer_private/show_permissions_dialog_helper.h"

+#include <utility>

#include "apps/app_load_service.h"

#include "apps/saved_files_service.h"

#include "base/metrics/histogram.h"

@@ -81,7 +83,7 @@ void ShowPermissionsDialogHelper::ShowPermissionsDialog(

ExtensionInstallPrompt::POST_INSTALL_PERMISSIONS_PROMPT));

prompt->set_retained_files(retained_file_paths);

prompt->set_retained_device_messages(retained_device_messages);

- prompt_->ShowDialog(this, extension, nullptr, prompt.Pass(),

+ prompt_->ShowDialog(this, extension, nullptr, std::move(prompt),

ExtensionInstallPrompt::GetDefaultShowDialogCallback());

}