Add thread affinity and ASSERT() for same-thread restriction to WTF::Function

Add thread affinity and ASSERT() for same-thread restriction to WTF::Function

This CL introduces ThreadAffinity (SameThreadAffinity or CrossThreadAffinity)
at type level to:
- WTF::Function,
- WTF::PartBoundFunctionImpl,
- blink::internal::CallClosureTaskBase,
- blink::internal::CallClosureTask, and
- blink::internal::CallClosureWithExecutionContextTask,
to detect misuse of thread affinity at compile time and
to prepare for merging with base::Bind() in the course of tzik@'s refactoring.

This CL also adds ASSERT()s for all same-thread WTF::Function, i.e.
ASSERT() that WTF::Function is created, executed and destructed on the same
thread if it has SameThreadAffinity.
This makes WTF::bind() to fail at runtime if used cross-thread.

This CL replaces WTF::Closure with:
- WTF::SameThreadClosure for same-thread closures and
- WTF::CrossThreadClosure for cross-thread closures,

blink::Task is also replaced with blink::SameThreadTask and
blink::CrossThreadTask, but WTF::SameThreadClosure/CrossThreadClosure should be
used instead where possible.

BUG=588224
Committed: https://crrev.com/960a5f598dfc112718a58b2c4b29248ef2fa5dca
Cr-Commit-Position: refs/heads/master@{#379614}

[hiroshige, 2015-12-25 08:45:24]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-25 08:45:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549143002/1

[commit-bot: I haz the power, 2015-12-25 09:20:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-25 09:20:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[hiroshige, 2016-01-27 12:35:05]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-27 12:35:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549143002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549143002/20001

[commit-bot: I haz the power, 2016-01-27 12:55:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 12:55:19]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[hiroshige, 2016-02-18 22:25:34]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-18 22:28:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549143002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549143002/40001

[hiroshige, 2016-02-18 22:43:10]

Description was changed from

==========
Add FunctionThreadAffinity to WTF::Function

BUG=
==========

to

==========
Add FunctionThreadAffinity to WTF::Function

This CL introduces ThreadAffinity to WTF::Function.
WTF::Function checks that WTF::Function is created, executed and destructed on
the same thread if ThreadAffinity is SameThread.
WTF::Closure SameThread, and introduces WTF::CrossThreadClosure.

WebTaskRunner:
postTask()/postDelayedTask()
->
postTask(): CrossThread
postTaskSameThread(): SameThread
postDelayedTaskSameThread(): SameThread

postTask(Task)
postDelayedTask(Task)
remain unannotated

WebThreadSupportingGC:
Remove postDelayedTask()
postTask(WebTaskRunner::Task) -> 
postTask(WebTaskRunner::Task): Unannotated
postTaskSameThread(): SameThread


blink::Task:
Now CrossThread.
SameThreadTask.

Fix ReverbConvolver.cpp
ScriptStreamer.cpp

Remove CallClosureTaskBase::m_isSameThread.

Microtask::enqueueMicrotask
Unannotated

BUG=
==========

[commit-bot: I haz the power, 2016-02-18 23:10:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 23:10:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hiroshige, 2016-02-19 22:59:16]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 23:05:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549143002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549143002/100001

[hiroshige, 2016-02-20 00:37:59]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[hiroshige, 2016-02-20 00:40:25]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2016-02-20 00:45:58]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-20 00:52:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549143002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549143002/180001

[commit-bot: I haz the power, 2016-02-20 02:11:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-20 02:11:23]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-02-21 18:47:32]

Description was changed from

==========
Add FunctionThreadAffinity to WTF::Function

This CL introduces ThreadAffinity to WTF::Function.
WTF::Function checks that WTF::Function is created, executed and destructed on
the same thread if ThreadAffinity is SameThread.
WTF::Closure SameThread, and introduces WTF::CrossThreadClosure.

WebTaskRunner:
postTask()/postDelayedTask()
->
postTask(): CrossThread
postTaskSameThread(): SameThread
postDelayedTaskSameThread(): SameThread

postTask(Task)
postDelayedTask(Task)
remain unannotated

WebThreadSupportingGC:
Remove postDelayedTask()
postTask(WebTaskRunner::Task) -> 
postTask(WebTaskRunner::Task): Unannotated
postTaskSameThread(): SameThread


blink::Task:
Now CrossThread.
SameThreadTask.

Fix ReverbConvolver.cpp
ScriptStreamer.cpp

Remove CallClosureTaskBase::m_isSameThread.

Microtask::enqueueMicrotask
Unannotated

BUG=
==========

to

==========
Add FunctionThreadAffinity to WTF::Function

This CL introduces ThreadAffinity to WTF::Function.
WTF::Function checks that WTF::Function is created, executed and destructed on
the same thread if ThreadAffinity is SameThreadAffinity.

Refactor CallClosureTaskBase, CallClosureTask and
CallClosureWithExecutionContextTask.

Closure -> CrossThreadClosure
Task -> SameThreadTask


WTF::Closure SameThread, and introduces WTF::CrossThreadClosure.

WebTaskRunner:
postTask()/postDelayedTask()
->
postTask(): CrossThread
postTaskSameThread(): SameThread
postDelayedTaskSameThread(): SameThread

postTask(Task)
postDelayedTask(Task)
remain unannotated

WebThreadSupportingGC:
Remove postDelayedTask()
postTask(WebTaskRunner::Task) -> 
postTask(WebTaskRunner::Task): Unannotated
postTaskSameThread(): SameThread


blink::Task:
Now CrossThread.
SameThreadTask.

Fix ReverbConvolver.cpp
ScriptStreamer.cpp

Remove CallClosureTaskBase::m_isSameThread.

Microtask::enqueueMicrotask
Unannotated

BUG=
==========

[hiroshige, 2016-02-21 19:43:40]

Description was changed from

==========
Add FunctionThreadAffinity to WTF::Function

This CL introduces ThreadAffinity to WTF::Function.
WTF::Function checks that WTF::Function is created, executed and destructed on
the same thread if ThreadAffinity is SameThreadAffinity.

Refactor CallClosureTaskBase, CallClosureTask and
CallClosureWithExecutionContextTask.

Closure -> CrossThreadClosure
Task -> SameThreadTask


WTF::Closure SameThread, and introduces WTF::CrossThreadClosure.

WebTaskRunner:
postTask()/postDelayedTask()
->
postTask(): CrossThread
postTaskSameThread(): SameThread
postDelayedTaskSameThread(): SameThread

postTask(Task)
postDelayedTask(Task)
remain unannotated

WebThreadSupportingGC:
Remove postDelayedTask()
postTask(WebTaskRunner::Task) -> 
postTask(WebTaskRunner::Task): Unannotated
postTaskSameThread(): SameThread


blink::Task:
Now CrossThread.
SameThreadTask.

Fix ReverbConvolver.cpp
ScriptStreamer.cpp

Remove CallClosureTaskBase::m_isSameThread.

Microtask::enqueueMicrotask
Unannotated

BUG=
==========

to

==========
[WIP] Add FunctionThreadAffinity to WTF::Function

This CL introduces ThreadAffinity to WTF::Function.
WTF::Function checks that WTF::Function is created, executed and destructed on
the same thread if ThreadAffinity is SameThreadAffinity.

This CL refactors CallClosureTaskBase, CallClosureTask and
CallClosureWithExecutionContextTask.
|CallClosureTaskBase::m_isSameThread| and its check is merged into
WTF::Function.

To Do:
- Fix names. Especially the following seems inconsistent.
    Closure -> Closure, CrossThreadClosure
    Task -> SameThreadTask, Task
- Send PSA to blink-dev.

BUG=588224
==========

[hiroshige, 2016-02-29 20:53:15]

Description was changed from

==========
[WIP] Add FunctionThreadAffinity to WTF::Function

This CL introduces ThreadAffinity to WTF::Function.
WTF::Function checks that WTF::Function is created, executed and destructed on
the same thread if ThreadAffinity is SameThreadAffinity.

This CL refactors CallClosureTaskBase, CallClosureTask and
CallClosureWithExecutionContextTask.
|CallClosureTaskBase::m_isSameThread| and its check is merged into
WTF::Function.

To Do:
- Fix names. Especially the following seems inconsistent.
    Closure -> Closure, CrossThreadClosure
    Task -> SameThreadTask, Task
- Send PSA to blink-dev.

BUG=588224
==========

to

==========
Add FunctionThreadAffinity to WTF::Function

This CL introduces ThreadAffinity to:
- WTF::Function,
- WTF::PartBoundFunctionImpl,
- blink::internal::CallClosureTaskBase,
- blink::internal::CallClosureTask, and
- blink::internal::CallClosureWithExecutionContextTask,
and adds ASSERT()s to check that WTF::Function is created, executed and
destructed on the same thread if it has SameThreadAffinity.

This CL replaces WTF::Closure (that currently used for both same-thread and
cross-thread closures) with:
- WTF::Closure for same-thread closures and
- WTF::CrossThreadClosure for cross-thread closures,

blink::Task is also replaced with blink::SameThreadTask and
blink::CrossThreadTask, but WTF::Closure/CrossThreadClosure should be instead
where possible.

BUG=588224
==========

[hiroshige, 2016-02-29 21:22:48]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-29 21:23:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549143002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549143002/240001

[hiroshige, 2016-03-01 01:46:36]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 01:47:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549143002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549143002/260001

[commit-bot: I haz the power, 2016-03-01 02:14:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 02:14:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hiroshige, 2016-03-02 02:24:44]

Description was changed from

==========
Add FunctionThreadAffinity to WTF::Function

This CL introduces ThreadAffinity to:
- WTF::Function,
- WTF::PartBoundFunctionImpl,
- blink::internal::CallClosureTaskBase,
- blink::internal::CallClosureTask, and
- blink::internal::CallClosureWithExecutionContextTask,
and adds ASSERT()s to check that WTF::Function is created, executed and
destructed on the same thread if it has SameThreadAffinity.

This CL replaces WTF::Closure (that currently used for both same-thread and
cross-thread closures) with:
- WTF::Closure for same-thread closures and
- WTF::CrossThreadClosure for cross-thread closures,

blink::Task is also replaced with blink::SameThreadTask and
blink::CrossThreadTask, but WTF::Closure/CrossThreadClosure should be instead
where possible.

BUG=588224
==========

to

==========
Add FunctionThreadAffinity to WTF::Function

This CL introduces ThreadAffinity (SameThreadAffinity or CrossThreadAffinity)
at type level to:
- WTF::Function,
- WTF::PartBoundFunctionImpl,
- blink::internal::CallClosureTaskBase,
- blink::internal::CallClosureTask, and
- blink::internal::CallClosureWithExecutionContextTask,
to detect misuse of thread affinity at compile time and
to prepare for merging with base::Bind() in the course of tzik@'s refactoring.

This CL also adds ASSERT()s for all same-thread WTF::Function, i.e.
ASSERT() that WTF::Function is created, executed and destructed on the same
thread if it has SameThreadAffinity.
This makes WTF::bind() to fail at runtime if used cross-thread.

This CL replaces WTF::Closure (that currently used for both same-thread and
cross-thread closures) with:
- WTF::Closure for same-thread closures and
- WTF::CrossThreadClosure for cross-thread closures,

blink::Task is also replaced with blink::SameThreadTask and
blink::CrossThreadTask, but WTF::Closure/CrossThreadClosure should be instead
where possible.

BUG=588224
==========

[hiroshige, 2016-03-02 02:24:44]

hiroshige@chromium.org changed reviewers:
+ haraken@chromium.org, kinuko@chromium.org, tzik@chromium.org

[hiroshige, 2016-03-02 02:27:23]

Description was changed from

==========
Add FunctionThreadAffinity to WTF::Function

This CL introduces ThreadAffinity (SameThreadAffinity or CrossThreadAffinity)
at type level to:
- WTF::Function,
- WTF::PartBoundFunctionImpl,
- blink::internal::CallClosureTaskBase,
- blink::internal::CallClosureTask, and
- blink::internal::CallClosureWithExecutionContextTask,
to detect misuse of thread affinity at compile time and
to prepare for merging with base::Bind() in the course of tzik@'s refactoring.

This CL also adds ASSERT()s for all same-thread WTF::Function, i.e.
ASSERT() that WTF::Function is created, executed and destructed on the same
thread if it has SameThreadAffinity.
This makes WTF::bind() to fail at runtime if used cross-thread.

This CL replaces WTF::Closure (that currently used for both same-thread and
cross-thread closures) with:
- WTF::Closure for same-thread closures and
- WTF::CrossThreadClosure for cross-thread closures,

blink::Task is also replaced with blink::SameThreadTask and
blink::CrossThreadTask, but WTF::Closure/CrossThreadClosure should be instead
where possible.

BUG=588224
==========

to

==========
Add thread affinity and ASSERT() for same-thread restriction to WTF::Function

This CL introduces ThreadAffinity (SameThreadAffinity or CrossThreadAffinity)
at type level to:
- WTF::Function,
- WTF::PartBoundFunctionImpl,
- blink::internal::CallClosureTaskBase,
- blink::internal::CallClosureTask, and
- blink::internal::CallClosureWithExecutionContextTask,
to detect misuse of thread affinity at compile time and
to prepare for merging with base::Bind() in the course of tzik@'s refactoring.

This CL also adds ASSERT()s for all same-thread WTF::Function, i.e.
ASSERT() that WTF::Function is created, executed and destructed on the same
thread if it has SameThreadAffinity.
This makes WTF::bind() to fail at runtime if used cross-thread.

This CL replaces WTF::Closure (that currently used for both same-thread and
cross-thread closures) with:
- WTF::Closure for same-thread closures and
- WTF::CrossThreadClosure for cross-thread closures,

blink::Task is also replaced with blink::SameThreadTask and
blink::CrossThreadTask, but WTF::Closure/CrossThreadClosure should be instead
where possible.

BUG=588224
==========

[hiroshige, 2016-03-02 02:28:02]

PTAL.

[kinuko, 2016-03-02 07:30:56]

lgtm

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/wtf/Functional.h (right):

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/wtf/Functional.h:216: void NEVER_INLINE checkThread()
sorry, why we need this to be noinline?

[haraken, 2016-03-02 09:27:35]

LGTM

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/Task.h (right):

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/Task.h:43: // Please use WTF::Closure and
WTF::CrossThreadClosure directly, instead of

Nit: I might prefer renaming WTF::Closure to WTF::SameThreadClosure in a follow
up CL. In general, it looks better to be explicit about same-thread or
cross-thread in method names.

[tzik, 2016-03-02 11:54:29]

lgtm

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/WebTaskRunner.cpp (right):

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/WebTaskRunner.cpp:18:
postDelayedTask(std::move(location), new CrossThreadTask(std::move(task)),
delayMs);
std::move(location) takes no effect. Can we just use bare |location| here (and
elsewhere in this file)?

[hiroshige, 2016-03-03 02:02:12]

Patchset #15 (id:280001) has been deleted

[hiroshige, 2016-03-03 02:07:30]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 02:08:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549143002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549143002/300001

[hiroshige, 2016-03-03 02:21:05]

hiroshige@chromium.org changed reviewers:
+ alexclarke@chromium.org, skyostil@chromium.org

[hiroshige, 2016-03-03 02:21:07]

+skyostil@ alexclarke@ in case you have concerns/conflicts with this.

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/Task.h (right):

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/Task.h:43: // Please use WTF::Closure and
WTF::CrossThreadClosure directly, instead of
On 2016/03/02 09:27:35, haraken wrote:
> 
> Nit: I might prefer renaming WTF::Closure to WTF::SameThreadClosure in a
follow
> up CL. In general, it looks better to be explicit about same-thread or
> cross-thread in method names.

Should we also rename bind() to sameThreadBind()?

tzik@, what do you think?
I prefer to rename Closure to SameThreadClosure to make it a more strong signal
for developers and users of postTask() functions.
But Closure/CrossThreadClosure might be more compatible with your planned names
of base::Callback family.

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/WebTaskRunner.cpp (right):

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/WebTaskRunner.cpp:18:
postDelayedTask(std::move(location), new CrossThreadTask(std::move(task)),
delayMs);
On 2016/03/02 11:54:29, tzik wrote:
> std::move(location) takes no effect. Can we just use bare |location| here (and
> elsewhere in this file)?

Done.

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/wtf/Functional.h (right):

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/wtf/Functional.h:216: void NEVER_INLINE checkThread()
On 2016/03/02 07:30:56, kinuko wrote:
> sorry, why we need this to be noinline?

This is to make checkThread() to appear in the crash stack trace to make
detection of violation easier.

[haraken, 2016-03-03 02:38:06]

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/Task.h (right):

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/Task.h:43: // Please use WTF::Closure and
WTF::CrossThreadClosure directly, instead of
On 2016/03/03 02:21:07, hiroshige wrote:
> On 2016/03/02 09:27:35, haraken wrote:
> > 
> > Nit: I might prefer renaming WTF::Closure to WTF::SameThreadClosure in a
> follow
> > up CL. In general, it looks better to be explicit about same-thread or
> > cross-thread in method names.
> 
> Should we also rename bind() to sameThreadBind()?
> 
> tzik@, what do you think?
> I prefer to rename Closure to SameThreadClosure to make it a more strong
signal
> for developers and users of postTask() functions.
> But Closure/CrossThreadClosure might be more compatible with your planned
names
> of base::Callback family.

I'd prefer having sameThreadBind & sameThreadCallback as well to give a better
signal to developers, but it's up to tzik@ and other chromium folks :)

[tzik, 2016-03-03 04:49:30]

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/Task.h (right):

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/Task.h:43: // Please use WTF::Closure and
WTF::CrossThreadClosure directly, instead of
It's up to you. :p
Since bind() in Blink is mostly used for cross-thread unlike to Chromium, it
seems plausible to state the thread-safety explicitly to prevent devs to find
bind() first.

But in Chromium, I want to use base::Bind() for thread-unsafe case rather than
introducing base::SameThreadBind(). I believe everything is assumed to be
thread-unsafe by default in Chromium, and thread-safe stuff is explicitly
annotated.
Since a half of base::Bind() usage are for same-thread tasks, I want to use a
short name for it.

[alex clarke (OOO till 29th), 2016-03-03 10:20:17]

LGTM

[hiroshige, 2016-03-03 21:39:10]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 21:39:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549143002/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549143002/340001

[hiroshige, 2016-03-03 21:42:00]

Description was changed from

==========
Add thread affinity and ASSERT() for same-thread restriction to WTF::Function

This CL introduces ThreadAffinity (SameThreadAffinity or CrossThreadAffinity)
at type level to:
- WTF::Function,
- WTF::PartBoundFunctionImpl,
- blink::internal::CallClosureTaskBase,
- blink::internal::CallClosureTask, and
- blink::internal::CallClosureWithExecutionContextTask,
to detect misuse of thread affinity at compile time and
to prepare for merging with base::Bind() in the course of tzik@'s refactoring.

This CL also adds ASSERT()s for all same-thread WTF::Function, i.e.
ASSERT() that WTF::Function is created, executed and destructed on the same
thread if it has SameThreadAffinity.
This makes WTF::bind() to fail at runtime if used cross-thread.

This CL replaces WTF::Closure (that currently used for both same-thread and
cross-thread closures) with:
- WTF::Closure for same-thread closures and
- WTF::CrossThreadClosure for cross-thread closures,

blink::Task is also replaced with blink::SameThreadTask and
blink::CrossThreadTask, but WTF::Closure/CrossThreadClosure should be instead
where possible.

BUG=588224
==========

to

==========
Add thread affinity and ASSERT() for same-thread restriction to WTF::Function

This CL introduces ThreadAffinity (SameThreadAffinity or CrossThreadAffinity)
at type level to:
- WTF::Function,
- WTF::PartBoundFunctionImpl,
- blink::internal::CallClosureTaskBase,
- blink::internal::CallClosureTask, and
- blink::internal::CallClosureWithExecutionContextTask,
to detect misuse of thread affinity at compile time and
to prepare for merging with base::Bind() in the course of tzik@'s refactoring.

This CL also adds ASSERT()s for all same-thread WTF::Function, i.e.
ASSERT() that WTF::Function is created, executed and destructed on the same
thread if it has SameThreadAffinity.
This makes WTF::bind() to fail at runtime if used cross-thread.

This CL replaces WTF::Closure with:
- WTF::SameThreadClosure for same-thread closures and
- WTF::CrossThreadClosure for cross-thread closures,

blink::Task is also replaced with blink::SameThreadTask and
blink::CrossThreadTask, but WTF::Closure/CrossThreadClosure should be instead
where possible.

BUG=588224
==========

[hiroshige, 2016-03-03 21:43:13]

Description was changed from

==========
Add thread affinity and ASSERT() for same-thread restriction to WTF::Function

This CL introduces ThreadAffinity (SameThreadAffinity or CrossThreadAffinity)
at type level to:
- WTF::Function,
- WTF::PartBoundFunctionImpl,
- blink::internal::CallClosureTaskBase,
- blink::internal::CallClosureTask, and
- blink::internal::CallClosureWithExecutionContextTask,
to detect misuse of thread affinity at compile time and
to prepare for merging with base::Bind() in the course of tzik@'s refactoring.

This CL also adds ASSERT()s for all same-thread WTF::Function, i.e.
ASSERT() that WTF::Function is created, executed and destructed on the same
thread if it has SameThreadAffinity.
This makes WTF::bind() to fail at runtime if used cross-thread.

This CL replaces WTF::Closure with:
- WTF::SameThreadClosure for same-thread closures and
- WTF::CrossThreadClosure for cross-thread closures,

blink::Task is also replaced with blink::SameThreadTask and
blink::CrossThreadTask, but WTF::Closure/CrossThreadClosure should be instead
where possible.

BUG=588224
==========

to

==========
Add thread affinity and ASSERT() for same-thread restriction to WTF::Function

This CL introduces ThreadAffinity (SameThreadAffinity or CrossThreadAffinity)
at type level to:
- WTF::Function,
- WTF::PartBoundFunctionImpl,
- blink::internal::CallClosureTaskBase,
- blink::internal::CallClosureTask, and
- blink::internal::CallClosureWithExecutionContextTask,
to detect misuse of thread affinity at compile time and
to prepare for merging with base::Bind() in the course of tzik@'s refactoring.

This CL also adds ASSERT()s for all same-thread WTF::Function, i.e.
ASSERT() that WTF::Function is created, executed and destructed on the same
thread if it has SameThreadAffinity.
This makes WTF::bind() to fail at runtime if used cross-thread.

This CL replaces WTF::Closure with:
- WTF::SameThreadClosure for same-thread closures and
- WTF::CrossThreadClosure for cross-thread closures,

blink::Task is also replaced with blink::SameThreadTask and
blink::CrossThreadTask, but WTF::SameThreadClosure/CrossThreadClosure should be
used instead where possible.

BUG=588224
==========

[commit-bot: I haz the power, 2016-03-03 21:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 21:53:47]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[hiroshige, 2016-03-03 22:20:27]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 22:21:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549143002/380001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549143002/380001

[commit-bot: I haz the power, 2016-03-03 23:02:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 23:02:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hiroshige, 2016-03-03 23:57:54]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-03 23:58:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549143002/380001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549143002/380001

[commit-bot: I haz the power, 2016-03-04 00:39:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-04 00:39:57]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-03-04 02:02:47]

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/Task.h (right):

https://codereview.chromium.org/1549143002/diff/260001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/Task.h:43: // Please use WTF::Closure and
WTF::CrossThreadClosure directly, instead of
On 2016/03/03 04:49:30, tzik wrote:
> It's up to you. :p
> Since bind() in Blink is mostly used for cross-thread unlike to Chromium, it
> seems plausible to state the thread-safety explicitly to prevent devs to find
> bind() first.
> 
> But in Chromium, I want to use base::Bind() for thread-unsafe case rather than
> introducing base::SameThreadBind(). I believe everything is assumed to be
> thread-unsafe by default in Chromium, and thread-safe stuff is explicitly
> annotated.
> Since a half of base::Bind() usage are for same-thread tasks, I want to use a
> short name for it.

Thanks for suggestions!
I renamed WTF::Closure to WTF::SameThreadClosure, as
postTask(PassOwnPtr<SameThreadClosure>) or so is clearer.
And use of WTF::Closure is relatively rare in Blink; most of developers uses
bind()+postTask() etc., without declaring interfaces using WTF::Closure. And
having limited number of functions that receives PassOwnPtr<Closure> is also
good. So assigning longer names both for same/cross-thread Closure is good in
Blink case.

I'll leave WTF::bind() as-is in this CL.

[hiroshige, 2016-03-05 02:09:24]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-05 02:09:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549143002/400001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549143002/400001

[commit-bot: I haz the power, 2016-03-05 04:38:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-05 04:38:40]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-03-07 04:21:38]

hiroshige@chromium.org changed reviewers:
+ jochen@chromium.org

[hiroshige, 2016-03-07 04:21:40]

+jochen, could you take a look?

[jochen (gone - plz use gerrit), 2016-03-07 12:03:15]

rubberstamp lgtm

[hiroshige, 2016-03-07 17:15:33]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-07 17:15:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549143002/400001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549143002/400001

[commit-bot: I haz the power, 2016-03-07 18:38:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-07 18:38:37]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-03-07 19:36:10]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-03-07 19:36:11]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
haraken@chromium.org, tzik@chromium.org, alexclarke@chromium.org
Link to the patchset: https://codereview.chromium.org/1549143002/#ps400001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-03-07 19:36:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1549143002/400001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1549143002/400001

[commit-bot: I haz the power, 2016-03-07 19:46:43]

Description was changed from

==========
Add thread affinity and ASSERT() for same-thread restriction to WTF::Function

This CL introduces ThreadAffinity (SameThreadAffinity or CrossThreadAffinity)
at type level to:
- WTF::Function,
- WTF::PartBoundFunctionImpl,
- blink::internal::CallClosureTaskBase,
- blink::internal::CallClosureTask, and
- blink::internal::CallClosureWithExecutionContextTask,
to detect misuse of thread affinity at compile time and
to prepare for merging with base::Bind() in the course of tzik@'s refactoring.

This CL also adds ASSERT()s for all same-thread WTF::Function, i.e.
ASSERT() that WTF::Function is created, executed and destructed on the same
thread if it has SameThreadAffinity.
This makes WTF::bind() to fail at runtime if used cross-thread.

This CL replaces WTF::Closure with:
- WTF::SameThreadClosure for same-thread closures and
- WTF::CrossThreadClosure for cross-thread closures,

blink::Task is also replaced with blink::SameThreadTask and
blink::CrossThreadTask, but WTF::SameThreadClosure/CrossThreadClosure should be
used instead where possible.

BUG=588224
==========

to

==========
Add thread affinity and ASSERT() for same-thread restriction to WTF::Function

This CL introduces ThreadAffinity (SameThreadAffinity or CrossThreadAffinity)
at type level to:
- WTF::Function,
- WTF::PartBoundFunctionImpl,
- blink::internal::CallClosureTaskBase,
- blink::internal::CallClosureTask, and
- blink::internal::CallClosureWithExecutionContextTask,
to detect misuse of thread affinity at compile time and
to prepare for merging with base::Bind() in the course of tzik@'s refactoring.

This CL also adds ASSERT()s for all same-thread WTF::Function, i.e.
ASSERT() that WTF::Function is created, executed and destructed on the same
thread if it has SameThreadAffinity.
This makes WTF::bind() to fail at runtime if used cross-thread.

This CL replaces WTF::Closure with:
- WTF::SameThreadClosure for same-thread closures and
- WTF::CrossThreadClosure for cross-thread closures,

blink::Task is also replaced with blink::SameThreadTask and
blink::CrossThreadTask, but WTF::SameThreadClosure/CrossThreadClosure should be
used instead where possible.

BUG=588224
==========

[commit-bot: I haz the power, 2016-03-07 19:46:45]

Committed patchset #20 (id:400001)

[commit-bot: I haz the power, 2016-03-07 19:47:48]

Description was changed from

==========
Add thread affinity and ASSERT() for same-thread restriction to WTF::Function

This CL introduces ThreadAffinity (SameThreadAffinity or CrossThreadAffinity)
at type level to:
- WTF::Function,
- WTF::PartBoundFunctionImpl,
- blink::internal::CallClosureTaskBase,
- blink::internal::CallClosureTask, and
- blink::internal::CallClosureWithExecutionContextTask,
to detect misuse of thread affinity at compile time and
to prepare for merging with base::Bind() in the course of tzik@'s refactoring.

This CL also adds ASSERT()s for all same-thread WTF::Function, i.e.
ASSERT() that WTF::Function is created, executed and destructed on the same
thread if it has SameThreadAffinity.
This makes WTF::bind() to fail at runtime if used cross-thread.

This CL replaces WTF::Closure with:
- WTF::SameThreadClosure for same-thread closures and
- WTF::CrossThreadClosure for cross-thread closures,

blink::Task is also replaced with blink::SameThreadTask and
blink::CrossThreadTask, but WTF::SameThreadClosure/CrossThreadClosure should be
used instead where possible.

BUG=588224
==========

to

==========
Add thread affinity and ASSERT() for same-thread restriction to WTF::Function

This CL introduces ThreadAffinity (SameThreadAffinity or CrossThreadAffinity)
at type level to:
- WTF::Function,
- WTF::PartBoundFunctionImpl,
- blink::internal::CallClosureTaskBase,
- blink::internal::CallClosureTask, and
- blink::internal::CallClosureWithExecutionContextTask,
to detect misuse of thread affinity at compile time and
to prepare for merging with base::Bind() in the course of tzik@'s refactoring.

This CL also adds ASSERT()s for all same-thread WTF::Function, i.e.
ASSERT() that WTF::Function is created, executed and destructed on the same
thread if it has SameThreadAffinity.
This makes WTF::bind() to fail at runtime if used cross-thread.

This CL replaces WTF::Closure with:
- WTF::SameThreadClosure for same-thread closures and
- WTF::CrossThreadClosure for cross-thread closures,

blink::Task is also replaced with blink::SameThreadTask and
blink::CrossThreadTask, but WTF::SameThreadClosure/CrossThreadClosure should be
used instead where possible.

BUG=588224

Committed: https://crrev.com/960a5f598dfc112718a58b2c4b29248ef2fa5dca
Cr-Commit-Position: refs/heads/master@{#379614}
==========

[commit-bot: I haz the power, 2016-03-07 19:47:50]

Patchset 20 (id:??) landed as
https://crrev.com/960a5f598dfc112718a58b2c4b29248ef2fa5dca
Cr-Commit-Position: refs/heads/master@{#379614}