third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h - Issue 1549143002: Add thread affinity and ASSERT() for same-thread restriction to WTF::Function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h

Issue 1549143002: Add thread affinity and ASSERT() for same-thread restriction to WTF::Function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TRV_ThreadSafeBindByVariadicTemplate

Patch Set: Rebase. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/workers/WorkerThread.cpp ('k') | third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h

diff --git a/third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h b/third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h

index 3601350c5352394b55aa8ea17f8d000c42baee6a..125a9595ac9f062dc130455b5d9f9035c1241e7f 100644

--- a/third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h

+++ b/third_party/WebKit/Source/modules/fetch/CrossThreadHolder.h

@@ -46,7 +46,7 @@ public:

// destructed (possibly on the calling thread or on the thread of

// |executionContext|) when |executionContext| is stopped or

// CrossThreadHolder is destructed.

- void postTask(PassOwnPtr<WTF::Function<void(T*, ExecutionContext*)>> task)

+ void postTask(PassOwnPtr<WTF::Function<void(T*, ExecutionContext*), WTF::CrossThreadAffinity>> task)

{

MutexLocker locker(m_mutex->mutex());

if (!m_bridge) {

@@ -119,7 +119,7 @@ private:

m_holder = nullptr;

}

- void runTask(PassOwnPtr<WTF::Function<void(T*, ExecutionContext*)>> task)

+ void runTask(PassOwnPtr<WTF::Function<void(T*, ExecutionContext*), WTF::CrossThreadAffinity>> task)

{

ASSERT(executionContext()->isContextThread());

if (m_obj)