components/password_manager/sync/browser/sync_credentials_filter.cc - Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/sync/browser/sync_credentials_filter.cc

Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad headers Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/common/credential_manager_types.cc ('k') | components/password_manager/sync/browser/sync_credentials_filter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/sync/browser/sync_credentials_filter.cc

diff --git a/components/password_manager/sync/browser/sync_credentials_filter.cc b/components/password_manager/sync/browser/sync_credentials_filter.cc

index e5ea09cdff2cfda5925963a25b8bc9ca253749f8..93031c7f2b1f0e5b4e2542bafbdbf0c286fc62b4 100644

--- a/components/password_manager/sync/browser/sync_credentials_filter.cc

+++ b/components/password_manager/sync/browser/sync_credentials_filter.cc

@@ -57,7 +57,7 @@ ScopedVector<PasswordForm> SyncCredentialsFilter::FilterResults(

(autofill_sync_state != DISALLOW_SYNC_CREDENTIALS_FOR_REAUTH ||

!LastLoadWasTransactionalReauthPage(

client_->GetLastCommittedEntryURL()))) {

- return results.Pass();

+ return results;

}

auto begin_of_removed =

@@ -72,7 +72,7 @@ ScopedVector<PasswordForm> SyncCredentialsFilter::FilterResults(

results.erase(begin_of_removed, results.end());

- return results.Pass();

+ return results;

}

bool SyncCredentialsFilter::ShouldSave(