components/password_manager/core/common/credential_manager_types.cc - Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/common/credential_manager_types.cc

Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad headers Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/test_password_store.cc ('k') | components/password_manager/sync/browser/sync_credentials_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/common/credential_manager_types.cc

diff --git a/components/password_manager/core/common/credential_manager_types.cc b/components/password_manager/core/common/credential_manager_types.cc

index acdff8d691643073391b8b59488ee97170f5181d..6af4a5096b81ab893ec9190ec7a1a6989ebe6479 100644

--- a/components/password_manager/core/common/credential_manager_types.cc

+++ b/components/password_manager/core/common/credential_manager_types.cc

@@ -42,7 +42,7 @@ scoped_ptr<autofill::PasswordForm> CreatePasswordFormFromCredentialInfo(

const GURL& origin) {

scoped_ptr<autofill::PasswordForm> form;

if (info.type == CredentialType::CREDENTIAL_TYPE_EMPTY)

- return form.Pass();

+ return form;

form.reset(new autofill::PasswordForm);

form->icon_url = info.icon;

@@ -58,7 +58,7 @@ scoped_ptr<autofill::PasswordForm> CreatePasswordFormFromCredentialInfo(

? origin.spec()

: "federation://" + origin.host() + "/" + info.federation.host();

form->username_value = info.id;

- return form.Pass();

+ return form;

}

bool CredentialInfo::operator==(const CredentialInfo& rhs) const {

return (type == rhs.type && id == rhs.id && name == rhs.name &&