components/password_manager/sync/browser/sync_credentials_filter_unittest.cc - Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad headers Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/sync/browser/sync_credentials_filter.cc ('k') | components/pdf/browser/pdf_web_contents_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

diff --git a/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc b/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

index 1efcba1eedda21c31f83a6a801ac570e79c458db..cc43857f56f56f3d40e60d7a36ccf667d97bc4f3 100644

--- a/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

+++ b/components/password_manager/sync/browser/sync_credentials_filter_unittest.cc

@@ -5,6 +5,7 @@

#include "components/password_manager/sync/browser/sync_credentials_filter.h"

#include <stddef.h>

+#include <utility>

#include "base/bind.h"

#include "base/bind_helpers.h"

@@ -43,7 +44,7 @@ class FakePasswordManagerClient : public StubPasswordManagerClient {

bool IsFormFiltered(const CredentialsFilter* filter, const PasswordForm& form) {

ScopedVector<PasswordForm> vector;

vector.push_back(new PasswordForm(form));

- vector = filter->FilterResults(vector.Pass());

+ vector = filter->FilterResults(std::move(vector));

return vector.empty();

}

@@ -257,7 +258,7 @@ TEST_F(CredentialsFilterTest, ShouldFilterOneForm) {

FakeSigninAs("test1@gmail.com");

- results = filter()->FilterResults(results.Pass());

+ results = filter()->FilterResults(std::move(results));

ASSERT_EQ(1u, results.size());

EXPECT_EQ(SimpleGaiaForm("test2@gmail.com"), *results[0]);