Make WebGL objects scriptwrappable so that binding integrity checks may be applied to them.

Make WebGL objects scriptwrappable so that binding integrity checks may be applied to them.

BUG=236671
R=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150929

[Tom Sepez, 2013-05-20 19:15:14]

Adam, please review.

[abarth-chromium, 2013-05-20 19:28:33]

@kbr: For context, we're adding this base class to objects that have JavaScript
wrappers >50% of the time to save memory and to harden the security of the
bindings.

[Ken Russell (switch to Gerrit), 2013-05-20 22:54:40]

If you want to cover all of the WebGL-related objects, the following also need
to be modified:

EXTDrawBuffers
EXTTextureFilterAnisotropic
OESElementIndexUint
OESStandardDerivatives
OESTextureFloat
OESTextureHalfFloat
OESVertexArrayObject
WebGLShaderPrecisionFormat
WebGLUniformLocation

https://chromiumcodereview.appspot.com/15481002/diff/1/Source/core/html/canva...
File Source/core/html/canvas/WebGLProgram.h (right):

https://chromiumcodereview.appspot.com/15481002/diff/1/Source/core/html/canva...
Source/core/html/canvas/WebGLProgram.h:38: class WebGLProgram : public
WebGLSharedObject {
Forgot to make this one ScriptWrappable and modify the constructor.

[Ken Russell (switch to Gerrit), 2013-05-21 01:41:37]

BTW, sorry, but there are more new WebGL extensions coming in
(OES_texture_float_linear, OES_texture_half_float_linear, EXT_frag_depth) which
will need the same set of changes.

Would you be able to handle these or do you need help doing so?

[Tom Sepez, 2013-05-21 16:54:41]

On 2013/05/21 01:41:37, kbr wrote:
> BTW, sorry, but there are more new WebGL extensions coming in
> (OES_texture_float_linear, OES_texture_half_float_linear, EXT_frag_depth)
which
> will need the same set of changes.
> 
> Would you be able to handle these or do you need help doing so?
Either way.  You can ping me when they land.  

I also have a version of the IDL CodeGenerator that spits out code to list the
nonn-scriptwrappable objects that I run from time to time.  These would show up
when I do that.

[Tom Sepez, 2013-05-21 17:46:04]

@kbr - please re-review. Thanks!

[Ken Russell (switch to Gerrit), 2013-05-21 20:43:01]

I hate to ask, but OESTextureFloatLinear and OESTextureHalfFloatLinear just
landed; would you mind taking care of them too?

https://codereview.chromium.org/15481002/diff/9001/Source/core/html/canvas/We...
File Source/core/html/canvas/WebGLProgram.h (right):

https://codereview.chromium.org/15481002/diff/9001/Source/core/html/canvas/We...
Source/core/html/canvas/WebGLProgram.h:38: class WebGLProgram : public
WebGLSharedObject {
Still missing the needed derivation from ScriptWrappable here and the associated
changes to the .cpp.

[Tom Sepez, 2013-05-21 20:45:07]

On 2013/05/21 20:43:01, kbr wrote:
> I hate to ask, but OESTextureFloatLinear and OESTextureHalfFloatLinear just
> landed; would you mind taking care of them too?
> 
I'd be happy to do that, glad you mentioned it.

>
https://codereview.chromium.org/15481002/diff/9001/Source/core/html/canvas/We...
> File Source/core/html/canvas/WebGLProgram.h (right):
> 
>
https://codereview.chromium.org/15481002/diff/9001/Source/core/html/canvas/We...
> Source/core/html/canvas/WebGLProgram.h:38: class WebGLProgram : public
> WebGLSharedObject {
> Still missing the needed derivation from ScriptWrappable here and the
associated
> changes to the .cpp.
D'oh.

[Tom Sepez, 2013-05-22 17:08:26]

@kbr - please re-re-review.

[Ken Russell (switch to Gerrit), 2013-05-22 18:39:06]

https://codereview.chromium.org/15481002/diff/28001/Source/core/html/canvas/W...
File Source/core/html/canvas/WebGLProgram.h (right):

https://codereview.chromium.org/15481002/diff/28001/Source/core/html/canvas/W...
Source/core/html/canvas/WebGLProgram.h:38: class WebGLProgram : public
WebGLSharedObject {
WebGLProgram still isn't fixed in this version of the CL.

[Tom Sepez, 2013-05-22 19:40:04]

ebGLSharedObject {
> WebGLProgram still isn't fixed in this version of the CL.
Sheesh.  I can't seem to do anything right today.  Please look now.

[Ken Russell (switch to Gerrit), 2013-05-22 19:51:07]

Thank you for persisting and taking care of this. LGTM

[commit-bot: I haz the power, 2013-05-22 19:55:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tsepez@chromium.org/15481002/37001

[commit-bot: I haz the power, 2013-05-22 22:17:46]

Change committed as 150929