Port android_webview_tests.gypi to GN.

Port android_webview_tests.gypi to GN.

BUG=532905
Committed: https://crrev.com/b08e2f5b80606182047db6bdf1c0094018e363ff
Cr-Commit-Position: refs/heads/master@{#367035}

[agrieve, 2015-12-22 16:39:26]

agrieve@chromium.org changed reviewers:
+ dpranke@chromium.org, michaelbai@chromium.org

[agrieve, 2015-12-22 16:39:26]

dpranke@chromium.org: Please review changes in //BUILD.gn

michaelbai@chromium.org: Please review changes in //android_webview

🎅

[Dirk Pranke, 2015-12-23 03:48:03]

https://codereview.chromium.org/1547683003/diff/1/android_webview/test/BUILD.gn
File android_webview/test/BUILD.gn (right):

https://codereview.chromium.org/1547683003/diff/1/android_webview/test/BUILD....
android_webview/test/BUILD.gn:18: android_apk("android_webview_apk") {
it seems confusing to a non-android person that we have both an
"android_webview_apk" that
is apparently test-only and a "android_webview" group that doesn't refer to it
but rather depends
on "system_webview_apk".

Does it make sense to add some comments somewhere explaining the naming, or is
this all self-explanatory to folks that work on android?

https://codereview.chromium.org/1547683003/diff/1/android_webview/test/BUILD....
android_webview/test/BUILD.gn:126: # 
"<(SHARED_INTERMEDIATE_DIR)/android_webview_unittests",
why are these commented out?

[agrieve, 2015-12-23 15:20:56]

https://codereview.chromium.org/1547683003/diff/1/android_webview/test/BUILD.gn
File android_webview/test/BUILD.gn (right):

https://codereview.chromium.org/1547683003/diff/1/android_webview/test/BUILD....
android_webview/test/BUILD.gn:18: android_apk("android_webview_apk") {
On 2015/12/23 03:48:03, Dirk Pranke wrote:
> it seems confusing to a non-android person that we have both an
> "android_webview_apk" that
> is apparently test-only and a "android_webview" group that doesn't refer to it
> but rather depends
> on "system_webview_apk".
> 
> Does it make sense to add some comments somewhere explaining the naming, or is
> this all self-explanatory to folks that work on android?

I'm likewise fairly confused by the naming, but wanted to keep the target names
the same as in GYP.

https://codereview.chromium.org/1547683003/diff/1/android_webview/test/BUILD....
android_webview/test/BUILD.gn:126: # 
"<(SHARED_INTERMEDIATE_DIR)/android_webview_unittests",
On 2015/12/23 03:48:03, Dirk Pranke wrote:
> why are these commented out?

That's a whoops. :P. Gone.

[Dirk Pranke, 2015-12-23 18:18:11]

okay. It might be good to add some comments to both places at some point (or
just add comments or change the names after we drop the GYP build).

lgtm.

[michaelbai, 2015-12-28 20:06:31]

Do we have bot to run the tests of GN build? If so, we may add webview test.

[agrieve, 2015-12-28 20:32:34]

On 2015/12/28 20:06:31, michaelbai wrote:
> Do we have bot to run the tests of GN build? If so, we may add webview test.

We do. I'll enable the webview tests in a follow-up.

[michaelbai, 2015-12-28 20:43:46]

lgtm

[agrieve, 2015-12-29 00:45:46]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-12-29 00:45:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelbai@chromium.org, dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1547683003/#ps40001
(title: "Add target x-refs")

[commit-bot: I haz the power, 2015-12-29 00:45:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1547683003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1547683003/40001

[commit-bot: I haz the power, 2015-12-29 01:17:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-29 01:18:52]

Description was changed from

==========
Port android_webview_tests.gypi to GN.

BUG=532905
==========

to

==========
Port android_webview_tests.gypi to GN.

BUG=532905

Committed: https://crrev.com/b08e2f5b80606182047db6bdf1c0094018e363ff
Cr-Commit-Position: refs/heads/master@{#367035}
==========

[commit-bot: I haz the power, 2015-12-29 01:18:53]

Patchset 3 (id:??) landed as
https://crrev.com/b08e2f5b80606182047db6bdf1c0094018e363ff
Cr-Commit-Position: refs/heads/master@{#367035}