Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1538393003: GN(android) Use DEPRECATED_java_in_dir for webview for now. (Closed)

Created:
4 years, 12 months ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
michaelbai
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@webview-tests-1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN(android) Use DEPRECATED_java_in_dir for webview for now. It was missing at least one source file, so until we make the GYP->GN switch, it's better to just use the glob. BUG=532905 Committed: https://crrev.com/ad4ca832d1f4c72b73577898919b5fb7cff8bca7 Cr-Commit-Position: refs/heads/master@{#367019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -57 lines) Patch
M android_webview/BUILD.gn View 2 chunks +1 line, -57 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (3 generated)
agrieve
Forget which file was missing, but we have a script to replace all DEPRECATED_java_in_dir with ...
4 years, 12 months ago (2015-12-22 16:38:52 UTC) #2
michaelbai
On 2015/12/22 16:38:52, agrieve wrote: > Forget which file was missing, but we have a ...
4 years, 11 months ago (2015-12-28 20:15:21 UTC) #3
michaelbai
lgtm
4 years, 11 months ago (2015-12-28 20:15:32 UTC) #4
agrieve
On 2015/12/28 20:15:21, michaelbai wrote: > On 2015/12/22 16:38:52, agrieve wrote: > > Forget which ...
4 years, 11 months ago (2015-12-28 20:32:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1538393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1538393003/1
4 years, 11 months ago (2015-12-28 21:50:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-28 22:33:42 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2015-12-28 22:34:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad4ca832d1f4c72b73577898919b5fb7cff8bca7
Cr-Commit-Position: refs/heads/master@{#367019}

Powered by Google App Engine
This is Rietveld 408576698