components/nacl/loader/BUILD.gn - Issue 1547463004: GN: Properly mark all NaCl test depencies as data_deps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/BUILD.gn

Issue 1547463004: GN: Properly mark all NaCl test depencies as data_deps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nacl_helper_nonsfi is not part of Linux installer Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/nacl/loader/BUILD.gn

diff --git a/components/nacl/loader/BUILD.gn b/components/nacl/loader/BUILD.gn

index db7a71dd77b6406ef3af12b4a906f4d0c5087d17..af7342893e4bcfc374d071790986deef1cd6cc91 100644

--- a/components/nacl/loader/BUILD.gn

+++ b/components/nacl/loader/BUILD.gn

@@ -140,7 +140,7 @@ if (is_linux) {

}

group("helper_nonsfi") {

- deps = [

+ data_deps = [

":nacl_helper_nonsfi_copy(//build/toolchain/nacl:newlib_pnacl_nonsfi)",

]

}

@@ -159,6 +159,7 @@ if (is_linux) {

testonly = true

data_deps = [

":helper_nonsfi_unittests",

+ ":nacl_helper_nonsfi_unittests_main_copy(//build/toolchain/nacl:newlib_pnacl_nonsfi)",

]

}

« no previous file with comments | « chrome/test/data/nacl/BUILD.gn ('k') | extensions/shell/BUILD.gn » ('j') | no next file with comments »