Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 1546933002: Ensure that all non-stable maps created by Map::AddMissingTransitions() are marked as such. (Closed)

Created:
5 years ago by Igor Sheludko
Modified:
4 years, 12 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure that all non-stable maps created by Map::AddMissingTransitions() are marked as such. BUG=chromium:570131 LOG=N Committed: https://crrev.com/5b3fbf231cca9777597021a131acdd47dc29024c Cr-Commit-Position: refs/heads/master@{#33029}

Patch Set 1 #

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/objects.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/objects-debug.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546933002/1
5 years ago (2015-12-23 10:53:45 UTC) #3
Igor Sheludko
PTAL
5 years ago (2015-12-23 10:54:27 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-23 11:35:35 UTC) #7
Camillo Bruni
LGTM (offline discussion resulted in adding a check in MapVerify to ensure the backpointer is ...
4 years, 12 months ago (2015-12-23 14:36:08 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546933002/40001
4 years, 12 months ago (2015-12-23 15:08:48 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-23 15:25:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546933002/40001
4 years, 12 months ago (2015-12-23 15:33:09 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 12 months ago (2015-12-23 15:35:02 UTC) #18
commit-bot: I haz the power
4 years, 12 months ago (2015-12-23 15:35:10 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b3fbf231cca9777597021a131acdd47dc29024c
Cr-Commit-Position: refs/heads/master@{#33029}

Powered by Google App Engine
This is Rietveld 408576698