Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1520613006: During property reconfiguring ensure that the first map that gets new descriptors is the one that o… (Closed)

Created:
5 years ago by Igor Sheludko
Modified:
5 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

During property reconfiguring ensure that the first map that gets new descriptors is the one that owns the whole descriptor array. This is necessary to guarantee that the whole descriptor would be marked, otherwise DescriptorArray pretenuring would cause crashes. Committed: https://crrev.com/5c3bfe8f57c6cb719e8f06adaf467b9dd70bf44d Cr-Commit-Position: refs/heads/master@{#32812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -75 lines) Patch
M src/objects.h View 3 chunks +14 lines, -10 lines 0 comments Download
M src/objects.cc View 6 chunks +80 lines, -52 lines 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -5 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 chunk +25 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520613006/1
5 years ago (2015-12-11 11:07:44 UTC) #2
Igor Sheludko
PTAL
5 years ago (2015-12-11 11:07:49 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-11 12:22:04 UTC) #6
Toon Verwaest
awesome, thanks for fixing this tricky issue :) lgtm
5 years ago (2015-12-11 15:14:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1520613006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1520613006/1
5 years ago (2015-12-11 16:21:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 16:41:08 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-11 16:41:56 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c3bfe8f57c6cb719e8f06adaf467b9dd70bf44d
Cr-Commit-Position: refs/heads/master@{#32812}

Powered by Google App Engine
This is Rietveld 408576698