Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: src/objects-debug.cc

Issue 1546933002: Ensure that all non-stable maps created by Map::AddMissingTransitions() are marked as such. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressing comments Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-field-type-tracking.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/objects.h" 5 #include "src/objects.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/disasm.h" 8 #include "src/disasm.h"
9 #include "src/disassembler.h" 9 #include "src/disassembler.h"
10 #include "src/macro-assembler.h" 10 #include "src/macro-assembler.h"
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 } 323 }
324 324
325 325
326 void Map::MapVerify() { 326 void Map::MapVerify() {
327 Heap* heap = GetHeap(); 327 Heap* heap = GetHeap();
328 CHECK(!heap->InNewSpace(this)); 328 CHECK(!heap->InNewSpace(this));
329 CHECK(FIRST_TYPE <= instance_type() && instance_type() <= LAST_TYPE); 329 CHECK(FIRST_TYPE <= instance_type() && instance_type() <= LAST_TYPE);
330 CHECK(instance_size() == kVariableSizeSentinel || 330 CHECK(instance_size() == kVariableSizeSentinel ||
331 (kPointerSize <= instance_size() && 331 (kPointerSize <= instance_size() &&
332 instance_size() < heap->Capacity())); 332 instance_size() < heap->Capacity()));
333 CHECK(GetBackPointer()->IsUndefined() ||
334 !Map::cast(GetBackPointer())->is_stable());
333 VerifyHeapPointer(prototype()); 335 VerifyHeapPointer(prototype());
334 VerifyHeapPointer(instance_descriptors()); 336 VerifyHeapPointer(instance_descriptors());
335 SLOW_DCHECK(instance_descriptors()->IsSortedNoDuplicates()); 337 SLOW_DCHECK(instance_descriptors()->IsSortedNoDuplicates());
336 SLOW_DCHECK(TransitionArray::IsSortedNoDuplicates(this)); 338 SLOW_DCHECK(TransitionArray::IsSortedNoDuplicates(this));
337 SLOW_DCHECK(TransitionArray::IsConsistentWithBackPointers(this)); 339 SLOW_DCHECK(TransitionArray::IsConsistentWithBackPointers(this));
338 // TODO(ishell): turn it back to SLOW_DCHECK. 340 // TODO(ishell): turn it back to SLOW_DCHECK.
339 CHECK(!FLAG_unbox_double_fields || 341 CHECK(!FLAG_unbox_double_fields ||
340 layout_descriptor()->IsConsistentWithMap(this)); 342 layout_descriptor()->IsConsistentWithMap(this));
341 } 343 }
342 344
(...skipping 965 matching lines...) Expand 10 before | Expand all | Expand 10 after
1308 1310
1309 // Both are done at the same time. 1311 // Both are done at the same time.
1310 CHECK_EQ(new_it.done(), old_it.done()); 1312 CHECK_EQ(new_it.done(), old_it.done());
1311 } 1313 }
1312 1314
1313 1315
1314 #endif // DEBUG 1316 #endif // DEBUG
1315 1317
1316 } // namespace internal 1318 } // namespace internal
1317 } // namespace v8 1319 } // namespace v8
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/cctest/test-field-type-tracking.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698