Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1546263002: Add a missing switch-case break in WebView UMA (Closed)

Created:
4 years, 12 months ago by tzik
Modified:
4 years, 11 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a missing switch-case break in WebView UMA BUG= Committed: https://crrev.com/39c9c16f7f1e47fc5808256bae9e39c2cae3aa5a Cr-Commit-Position: refs/heads/master@{#367077}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M extensions/browser/guest_view/web_view/web_view_permission_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546263002/1
4 years, 12 months ago (2015-12-27 23:53:33 UTC) #2
tzik
PTAL. This switch-case looks suspicious to me. Can I add a break here? Or, if ...
4 years, 12 months ago (2015-12-27 23:58:41 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-28 01:50:28 UTC) #6
lazyboy
lgtm, thanks!
4 years, 11 months ago (2015-12-29 16:18:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1546263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1546263002/1
4 years, 11 months ago (2015-12-29 16:19:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-29 17:21:39 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-12-29 17:22:40 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/39c9c16f7f1e47fc5808256bae9e39c2cae3aa5a
Cr-Commit-Position: refs/heads/master@{#367077}

Powered by Google App Engine
This is Rietveld 408576698