Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Side by Side Diff: extensions/browser/guest_view/web_view/web_view_permission_helper.cc

Issue 1546263002: Add a missing switch-case break in WebView UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/guest_view/web_view/web_view_permission_helper.h" 5 #include "extensions/browser/guest_view/web_view/web_view_permission_helper.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "components/guest_view/browser/guest_view_event.h" 9 #include "components/guest_view/browser/guest_view_event.h"
10 #include "content/public/browser/render_process_host.h" 10 #include "content/public/browser/render_process_host.h"
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 content::RecordAction( 75 content::RecordAction(
76 UserMetricsAction("WebView.PermissionAllow.Geolocation")); 76 UserMetricsAction("WebView.PermissionAllow.Geolocation"));
77 break; 77 break;
78 case WEB_VIEW_PERMISSION_TYPE_JAVASCRIPT_DIALOG: 78 case WEB_VIEW_PERMISSION_TYPE_JAVASCRIPT_DIALOG:
79 content::RecordAction( 79 content::RecordAction(
80 UserMetricsAction("WebView.PermissionAllow.JSDialog")); 80 UserMetricsAction("WebView.PermissionAllow.JSDialog"));
81 break; 81 break;
82 case WEB_VIEW_PERMISSION_TYPE_LOAD_PLUGIN: 82 case WEB_VIEW_PERMISSION_TYPE_LOAD_PLUGIN:
83 content::RecordAction( 83 content::RecordAction(
84 UserMetricsAction("WebView.Guest.PermissionAllow.PluginLoad")); 84 UserMetricsAction("WebView.Guest.PermissionAllow.PluginLoad"));
85 break;
85 case WEB_VIEW_PERMISSION_TYPE_MEDIA: 86 case WEB_VIEW_PERMISSION_TYPE_MEDIA:
86 content::RecordAction( 87 content::RecordAction(
87 UserMetricsAction("WebView.PermissionAllow.Media")); 88 UserMetricsAction("WebView.PermissionAllow.Media"));
88 break; 89 break;
89 case WEB_VIEW_PERMISSION_TYPE_NEW_WINDOW: 90 case WEB_VIEW_PERMISSION_TYPE_NEW_WINDOW:
90 content::RecordAction( 91 content::RecordAction(
91 UserMetricsAction("BrowserPlugin.PermissionAllow.NewWindow")); 92 UserMetricsAction("BrowserPlugin.PermissionAllow.NewWindow"));
92 break; 93 break;
93 case WEB_VIEW_PERMISSION_TYPE_POINTER_LOCK: 94 case WEB_VIEW_PERMISSION_TYPE_POINTER_LOCK:
94 content::RecordAction( 95 content::RecordAction(
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 bool allowed_by_default) 401 bool allowed_by_default)
401 : callback(callback), 402 : callback(callback),
402 permission_type(permission_type), 403 permission_type(permission_type),
403 allowed_by_default(allowed_by_default) { 404 allowed_by_default(allowed_by_default) {
404 } 405 }
405 406
406 WebViewPermissionHelper::PermissionResponseInfo::~PermissionResponseInfo() { 407 WebViewPermissionHelper::PermissionResponseInfo::~PermissionResponseInfo() {
407 } 408 }
408 409
409 } // namespace extensions 410 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698