extensions/browser/guest_view/web_view/web_view_permission_helper.cc - Issue 1546263002: Add a missing switch-case break in WebView UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_permission_helper.cc

Issue 1546263002: Add a missing switch-case break in WebView UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/guest_view/web_view/web_view_permission_helper.cc

diff --git a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

index 462f23a028c0e00ad548df7eab868b4582a1af20..d8c78067445b5baa858e58f2eea1c8c9b15d55c8 100644

--- a/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

+++ b/extensions/browser/guest_view/web_view/web_view_permission_helper.cc

@@ -82,6 +82,7 @@ void RecordUserInitiatedUMA(

case WEB_VIEW_PERMISSION_TYPE_LOAD_PLUGIN:

content::RecordAction(

UserMetricsAction("WebView.Guest.PermissionAllow.PluginLoad"));

+ break;

case WEB_VIEW_PERMISSION_TYPE_MEDIA:

content::RecordAction(

UserMetricsAction("WebView.PermissionAllow.Media"));

« no previous file with comments | « no previous file | no next file » | no next file with comments »