Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1545283002: Convert Pass()→std::move() in //chrome/browser/ui (Closed)

Created:
4 years, 12 months ago by dcheng
Modified:
4 years, 12 months ago
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //chrome/browser/ui ☃ BUG=557422 R=avi@chromium.org TBR=kinuko@chromium.org Committed: https://crrev.com/1140ec269604bc588e2d3b61171c713a98135ea8 Cr-Commit-Position: refs/heads/master@{#366912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+510 lines, -505 lines) Patch
M chrome/browser/sync_file_system/drive_backend/callback_tracker_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/conflict_resolver.cc View 12 chunks +24 lines, -23 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_sync_worker.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/folder_creator.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/leveldb_wrapper.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task.cc View 5 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task_unittest.cc View 3 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc View 37 chunks +61 lines, -63 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 34 chunks +40 lines, -39 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk_unittest.cc View 21 chunks +32 lines, -32 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc View 7 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc View 7 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc View 41 chunks +66 lines, -69 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 8 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_context.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.cc View 14 chunks +24 lines, -23 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer_unittest.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc View 12 chunks +28 lines, -30 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_token.cc View 6 chunks +11 lines, -14 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/sync_file_system/local/canned_syncable_file_system.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/sync_file_system_backend.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_operation.cc View 10 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_factory.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/sync_process_runner.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/sync_process_runner_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
+avi for general review / sanity check +kinuko for OWNERS review
4 years, 12 months ago (2015-12-26 21:34:37 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545283002/1
4 years, 12 months ago (2015-12-26 21:34:54 UTC) #3
Avi (use Gerrit)
lgtm stampity stamp
4 years, 12 months ago (2015-12-26 21:58:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 12 months ago (2015-12-26 22:16:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1545283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1545283002/1
4 years, 12 months ago (2015-12-26 22:24:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-26 22:30:19 UTC) #9
commit-bot: I haz the power
4 years, 12 months ago (2015-12-26 22:31:15 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1140ec269604bc588e2d3b61171c713a98135ea8
Cr-Commit-Position: refs/heads/master@{#366912}

Powered by Google App Engine
This is Rietveld 408576698