Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc

Issue 1545283002: Convert Pass()→std::move() in //chrome/browser/ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync_file_system/drive_backend/conflict_resolver.h" 5 #include "chrome/browser/sync_file_system/drive_backend/conflict_resolver.h"
6 6
7 #include <utility>
8
7 #include "base/bind.h" 9 #include "base/bind.h"
8 #include "base/callback.h" 10 #include "base/callback.h"
9 #include "base/files/file_util.h" 11 #include "base/files/file_util.h"
10 #include "base/files/scoped_temp_dir.h" 12 #include "base/files/scoped_temp_dir.h"
11 #include "base/macros.h" 13 #include "base/macros.h"
12 #include "base/run_loop.h" 14 #include "base/run_loop.h"
13 #include "base/thread_task_runner_handle.h" 15 #include "base/thread_task_runner_handle.h"
14 #include "chrome/browser/sync_file_system/drive_backend/drive_backend_constants. h" 16 #include "chrome/browser/sync_file_system/drive_backend/drive_backend_constants. h"
15 #include "chrome/browser/sync_file_system/drive_backend/drive_backend_test_util. h" 17 #include "chrome/browser/sync_file_system/drive_backend/drive_backend_test_util. h"
16 #include "chrome/browser/sync_file_system/drive_backend/fake_drive_service_helpe r.h" 18 #include "chrome/browser/sync_file_system/drive_backend/fake_drive_service_helpe r.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 scoped_ptr<FakeDriveServiceWrapper> 64 scoped_ptr<FakeDriveServiceWrapper>
63 fake_drive_service(new FakeDriveServiceWrapper); 65 fake_drive_service(new FakeDriveServiceWrapper);
64 scoped_ptr<drive::DriveUploaderInterface> 66 scoped_ptr<drive::DriveUploaderInterface>
65 drive_uploader(new FakeDriveUploader(fake_drive_service.get())); 67 drive_uploader(new FakeDriveUploader(fake_drive_service.get()));
66 fake_drive_helper_.reset( 68 fake_drive_helper_.reset(
67 new FakeDriveServiceHelper(fake_drive_service.get(), 69 new FakeDriveServiceHelper(fake_drive_service.get(),
68 drive_uploader.get(), 70 drive_uploader.get(),
69 kSyncRootFolderTitle)); 71 kSyncRootFolderTitle));
70 remote_change_processor_.reset(new FakeRemoteChangeProcessor); 72 remote_change_processor_.reset(new FakeRemoteChangeProcessor);
71 73
72 context_.reset(new SyncEngineContext(fake_drive_service.Pass(), 74 context_.reset(new SyncEngineContext(
73 drive_uploader.Pass(), 75 std::move(fake_drive_service), std::move(drive_uploader),
74 nullptr /* task_logger */, 76 nullptr /* task_logger */, base::ThreadTaskRunnerHandle::Get(),
75 base::ThreadTaskRunnerHandle::Get(), 77 base::ThreadTaskRunnerHandle::Get(), nullptr /* worker_pool */));
76 base::ThreadTaskRunnerHandle::Get(),
77 nullptr /* worker_pool */));
78 context_->SetRemoteChangeProcessor(remote_change_processor_.get()); 78 context_->SetRemoteChangeProcessor(remote_change_processor_.get());
79 79
80 RegisterSyncableFileSystem(); 80 RegisterSyncableFileSystem();
81 81
82 sync_task_manager_.reset(new SyncTaskManager( 82 sync_task_manager_.reset(new SyncTaskManager(
83 base::WeakPtr<SyncTaskManager::Client>(), 83 base::WeakPtr<SyncTaskManager::Client>(),
84 10 /* maximum_background_task */, 84 10 /* maximum_background_task */,
85 base::ThreadTaskRunnerHandle::Get(), 85 base::ThreadTaskRunnerHandle::Get(),
86 nullptr /* worker_pool */)); 86 nullptr /* worker_pool */));
87 sync_task_manager_->Initialize(SYNC_STATUS_OK); 87 sync_task_manager_->Initialize(SYNC_STATUS_OK);
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 return status; 241 return status;
242 } 242 }
243 243
244 ScopedVector<google_apis::FileResource> 244 ScopedVector<google_apis::FileResource>
245 GetResourceEntriesForParentAndTitle(const std::string& parent_folder_id, 245 GetResourceEntriesForParentAndTitle(const std::string& parent_folder_id,
246 const std::string& title) { 246 const std::string& title) {
247 ScopedVector<google_apis::FileResource> entries; 247 ScopedVector<google_apis::FileResource> entries;
248 EXPECT_EQ(google_apis::HTTP_SUCCESS, 248 EXPECT_EQ(google_apis::HTTP_SUCCESS,
249 fake_drive_helper_->SearchByTitle( 249 fake_drive_helper_->SearchByTitle(
250 parent_folder_id, title, &entries)); 250 parent_folder_id, title, &entries));
251 return entries.Pass(); 251 return entries;
252 } 252 }
253 253
254 void VerifyConflictResolution( 254 void VerifyConflictResolution(
255 const std::string& parent_folder_id, 255 const std::string& parent_folder_id,
256 const std::string& title, 256 const std::string& title,
257 const std::string& primary_file_id, 257 const std::string& primary_file_id,
258 test_util::FileResourceKind kind) { 258 test_util::FileResourceKind kind) {
259 ScopedVector<google_apis::FileResource> entries; 259 ScopedVector<google_apis::FileResource> entries;
260 EXPECT_EQ(google_apis::HTTP_SUCCESS, 260 EXPECT_EQ(google_apis::HTTP_SUCCESS,
261 fake_drive_helper_->SearchByTitle( 261 fake_drive_helper_->SearchByTitle(
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 520
521 EXPECT_EQ(4, CountParents(file)); 521 EXPECT_EQ(4, CountParents(file));
522 522
523 EXPECT_EQ(SYNC_STATUS_OK, RunConflictResolver()); 523 EXPECT_EQ(SYNC_STATUS_OK, RunConflictResolver());
524 524
525 EXPECT_EQ(1, CountParents(file)); 525 EXPECT_EQ(1, CountParents(file));
526 } 526 }
527 527
528 } // namespace drive_backend 528 } // namespace drive_backend
529 } // namespace sync_file_system 529 } // namespace sync_file_system
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698