chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc - Issue 1545283002: Convert Pass()→std::move() in //chrome/browser/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc

Issue 1545283002: Convert Pass()→std::move() in //chrome/browser/ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc ('k') | chrome/browser/sync_file_system/drive_backend/fake_sync_worker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc b/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc

index ab18a355b1236243668f60c3f13a4e8ba57cb6a9..c0c085eed9c7ac7c952a37ec91e3fdb667a0150a 100644

--- a/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc

+++ b/chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.h"

+#include <utility>

#include "base/bind.h"

#include "base/files/file_util.h"

#include "base/message_loop/message_loop.h"

@@ -35,7 +37,7 @@ void UploadResultCallback(DriveApiErrorCode* error_out,

ASSERT_TRUE(error_out);

ASSERT_TRUE(entry_out);

*error_out = error;

- *entry_out = entry.Pass();

+ *entry_out = std::move(entry);

}

void DownloadResultCallback(DriveApiErrorCode* error_out,

@@ -239,7 +241,7 @@ DriveApiErrorCode FakeDriveServiceHelper::ListFilesInFolder(

if (error != google_apis::HTTP_SUCCESS)

return error;

- return CompleteListing(list.Pass(), entries);

+ return CompleteListing(std::move(list), entries);

}

DriveApiErrorCode FakeDriveServiceHelper::SearchByTitle(

@@ -255,7 +257,7 @@ DriveApiErrorCode FakeDriveServiceHelper::SearchByTitle(

if (error != google_apis::HTTP_SUCCESS)

return error;

- return CompleteListing(list.Pass(), entries);

+ return CompleteListing(std::move(list), entries);

}

DriveApiErrorCode FakeDriveServiceHelper::GetFileResource(