third_party/WebKit/Source/core/svg/SVGStringList.h - Issue 1544673003: Refactor propagation of parsing errors for SVG attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGStringList.h

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/svg/SVGNumber.cpp ('K') | « third_party/WebKit/Source/core/svg/SVGString.h ('k') | third_party/WebKit/Source/core/svg/SVGStringList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGStringList.h

diff --git a/third_party/WebKit/Source/core/svg/SVGStringList.h b/third_party/WebKit/Source/core/svg/SVGStringList.h

index a787c523426e5df43d1fec9a8108cf206f8c8458..c11286b69e432e5ed8d1d2bb09b270d5bf2e618f 100644

--- a/third_party/WebKit/Source/core/svg/SVGStringList.h

+++ b/third_party/WebKit/Source/core/svg/SVGStringList.h

@@ -31,12 +31,13 @@

#ifndef SVGStringList_h

#define SVGStringList_h

-#include "bindings/core/v8/ScriptWrappable.h"

+#include "core/svg/SVGParsingError.h"

#include "core/svg/SVGString.h"

#include "core/svg/properties/SVGPropertyHelper.h"

namespace blink {

+class ExceptionState;

class SVGStringListTearOff;

// Implementation of SVGStringList spec:

@@ -74,7 +75,7 @@ public:

void replaceItem(const String&, size_t, ExceptionState&);

// SVGPropertyBase:

- void setValueAsString(const String&, ExceptionState&);

+ SVGParsingError setValueAsString(const String&);

String valueAsString() const override;

void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;