Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: third_party/WebKit/Source/core/svg/SVGElement.cpp

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGElement.cpp
index 81a4381df3dde32aaadbd659940b176096fcd3e3..c7f4aec535e431fb8df84b0da38f06d7ed66e0a8 100644
--- a/third_party/WebKit/Source/core/svg/SVGElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGElement.cpp
@@ -635,8 +635,7 @@ bool SVGElement::inUseShadowTree() const
void SVGElement::parseAttribute(const QualifiedName& name, const AtomicString& oldValue, const AtomicString& value)
{
if (SVGAnimatedPropertyBase* property = propertyFromAttribute(name)) {
- SVGParsingError parseError = NoError;
- property->setBaseValueAsString(value, parseError);
+ SVGParsingError parseError = property->setBaseValueAsString(value);
reportAttributeParsingError(parseError, name, value);
return;
}
@@ -646,8 +645,7 @@ void SVGElement::parseAttribute(const QualifiedName& name, const AtomicString& o
// the className here. svgAttributeChanged actually causes the resulting
// style updates (instead of Element::parseAttribute). We don't
// tell Element about the change to avoid parsing the class list twice
- SVGParsingError parseError = NoError;
- m_className->setBaseValueAsString(value, parseError);
+ SVGParsingError parseError = m_className->setBaseValueAsString(value);
reportAttributeParsingError(parseError, name, value);
} else if (name == tabindexAttr) {
Element::parseAttribute(name, oldValue, value);

Powered by Google App Engine
This is Rietveld 408576698