third_party/WebKit/Source/core/svg/SVGEnumeration.h - Issue 1544673003: Refactor propagation of parsing errors for SVG attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGEnumeration.h

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp ('K') | « third_party/WebKit/Source/core/svg/SVGElement.cpp ('k') | third_party/WebKit/Source/core/svg/SVGEnumeration.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGNumber.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGEnumeration.h

diff --git a/third_party/WebKit/Source/core/svg/SVGEnumeration.h b/third_party/WebKit/Source/core/svg/SVGEnumeration.h

index 62758d74f267c4dd135ba28c0f5bbba67f96a230..3eda15a623d032302b6759537db729e8006909ef 100644

--- a/third_party/WebKit/Source/core/svg/SVGEnumeration.h

+++ b/third_party/WebKit/Source/core/svg/SVGEnumeration.h

@@ -31,12 +31,11 @@

#ifndef SVGEnumeration_h

#define SVGEnumeration_h

+#include "core/svg/SVGParsingError.h"

#include "core/svg/properties/SVGProperty.h"

namespace blink {

-class ExceptionState;

class SVGEnumerationBase : public SVGPropertyBase {

public:

typedef std::pair<unsigned short, String> StringEntry;

@@ -56,7 +55,7 @@ public:

PassRefPtrWillBeRawPtr<SVGPropertyBase> cloneForAnimation(const String&) const override;

String valueAsString() const override;

- void setValueAsString(const String&, ExceptionState&);

+ SVGParsingError setValueAsString(const String&);

void add(PassRefPtrWillBeRawPtr<SVGPropertyBase>, SVGElement*) override;

void calculateAnimatedValue(SVGAnimationElement*, float percentage, unsigned repeatCount, PassRefPtrWillBeRawPtr<SVGPropertyBase> from, PassRefPtrWillBeRawPtr<SVGPropertyBase> to, PassRefPtrWillBeRawPtr<SVGPropertyBase> toAtEndOfDurationValue, SVGElement*) override;