Refactor propagation of parsing errors for SVG attributes

third_party/WebKit/Source/core/svg/SVGElement.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2008 Rob Buis <buis@kde.org>
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Alp Toker <alp@atoker.com>
  * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 617 matching lines @@
 }
 
 bool SVGElement::inUseShadowTree() const
 {
     return correspondingUseElement();
 }
 
 void SVGElement::parseAttribute(const QualifiedName& name, const AtomicString& oldValue, const AtomicString& value)
 {
     if (SVGAnimatedPropertyBase* property = propertyFromAttribute(name)) {
-        SVGParsingError parseError = NoError;
-        property->setBaseValueAsString(value, parseError);
+        SVGParsingError parseError = property->setBaseValueAsString(value);
         reportAttributeParsingError(parseError, name, value);
         return;
     }
 
     if (name == HTMLNames::classAttr) {
         // SVG animation has currently requires special storage of values so we set
         // the className here. svgAttributeChanged actually causes the resulting
         // style updates (instead of Element::parseAttribute). We don't
         // tell Element about the change to avoid parsing the class list twice
-        SVGParsingError parseError = NoError;
-        m_className->setBaseValueAsString(value, parseError);
+        SVGParsingError parseError = m_className->setBaseValueAsString(value);
         reportAttributeParsingError(parseError, name, value);
     } else if (name == tabindexAttr) {
         Element::parseAttribute(name, oldValue, value);
     } else {
         // standard events
         const AtomicString& eventName = HTMLElement::eventNameForAttributeName(name);
         if (!eventName.isNull())
             setAttributeEventListener(eventName, createAttributeEventListener(this, name, value, eventParameterName()));
         else
             Element::parseAttribute(name, oldValue, value);
@@ skipping 582 matching lines @@
     Element::trace(visitor);
 }
 
 const AtomicString& SVGElement::eventParameterName()
 {
     DEFINE_STATIC_LOCAL(const AtomicString, evtString, ("evt", AtomicString::ConstructFromLiteral));
     return evtString;
 }
 
 } // namespace blink