Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp b/third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp
index 2bd0f16b6342142af4c0da4b768d36f8311c3a70..7a2b26a6f1dac61bf5496a2cc817d4aab49dfe2e 100644
--- a/third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp
@@ -30,28 +30,25 @@
#include "core/svg/SVGAnimatedLength.h"
-#include "core/svg/SVGElement.h"
#include "core/svg/SVGLength.h"
namespace blink {
void SVGAnimatedLength::setDefaultValueAsString(const String& value)
{
- baseValue()->setValueAsString(value, ASSERT_NO_EXCEPTION);
+ baseValue()->setValueAsString(value);
}
-void SVGAnimatedLength::setBaseValueAsString(const String& value, SVGParsingError& parseError)
+SVGParsingError SVGAnimatedLength::setBaseValueAsString(const String& value)
{
- TrackExceptionState es;
+ SVGParsingError parseStatus = baseValue()->setValueAsString(value);
- baseValue()->setValueAsString(value, es);
-
- if (es.hadException()) {
- parseError = ParsingAttributeFailedError;
+ if (parseStatus != NoError)
baseValue()->newValueSpecifiedUnits(CSSPrimitiveValue::UnitType::UserUnits, 0);
- } else if (SVGLength::negativeValuesForbiddenForAnimatedLengthAttribute(attributeName()) && baseValue()->valueInSpecifiedUnits() < 0) {
- parseError = NegativeValueForbiddenError;
- }
+ else if (SVGLength::negativeValuesForbiddenForAnimatedLengthAttribute(attributeName()) && baseValue()->valueInSpecifiedUnits() < 0)
+ parseStatus = NegativeValueForbiddenError;
+
+ return parseStatus;
}
}

Powered by Google App Engine
This is Rietveld 408576698