Refactor propagation of parsing errors for SVG attributes

third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp

 /*
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 12 matching lines @@
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/svg/SVGAnimatedLength.h"
 
-#include "core/svg/SVGElement.h"
 #include "core/svg/SVGLength.h"
 
 namespace blink {
 
 void SVGAnimatedLength::setDefaultValueAsString(const String& value)
 {
-    baseValue()->setValueAsString(value, ASSERT_NO_EXCEPTION);
+    baseValue()->setValueAsString(value);
 }
 
-void SVGAnimatedLength::setBaseValueAsString(const String& value, SVGParsingError& parseError)
+SVGParsingError SVGAnimatedLength::setBaseValueAsString(const String& value)
 {
-    TrackExceptionState es;
+    SVGParsingError parseStatus = baseValue()->setValueAsString(value);
 
-    baseValue()->setValueAsString(value, es);
+    if (parseStatus != NoError)
+        baseValue()->newValueSpecifiedUnits(CSSPrimitiveValue::UnitType::UserUnits, 0);
+    else if (SVGLength::negativeValuesForbiddenForAnimatedLengthAttribute(attributeName()) && baseValue()->valueInSpecifiedUnits() < 0)
+        parseStatus = NegativeValueForbiddenError;
 
-    if (es.hadException()) {
-        parseError = ParsingAttributeFailedError;
-        baseValue()->newValueSpecifiedUnits(CSSPrimitiveValue::UnitType::UserUnits, 0);
-    } else if (SVGLength::negativeValuesForbiddenForAnimatedLengthAttribute(attributeName()) && baseValue()->valueInSpecifiedUnits() < 0) {
-        parseError = NegativeValueForbiddenError;
-    }
+    return parseStatus;
 }
 
 }