third_party/WebKit/Source/core/svg/SVGAnimatedLength.h - Issue 1544673003: Refactor propagation of parsing errors for SVG attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGAnimatedLength.h

Issue 1544673003: Refactor propagation of parsing errors for SVG attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp ('K') | « third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp ('k') | third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGNumber.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGAnimatedLength.h

diff --git a/third_party/WebKit/Source/core/svg/SVGAnimatedLength.h b/third_party/WebKit/Source/core/svg/SVGAnimatedLength.h

index dc4ba7de076e0e49aa967bd24cb262a833ad10cc..6ef65684d7307710308d75d3140121179b0e32da 100644

--- a/third_party/WebKit/Source/core/svg/SVGAnimatedLength.h

+++ b/third_party/WebKit/Source/core/svg/SVGAnimatedLength.h

@@ -45,7 +45,7 @@ public:

}

void setDefaultValueAsString(const String&);

- void setBaseValueAsString(const String&, SVGParsingError&) override;

+ SVGParsingError setBaseValueAsString(const String&) override;

protected:

SVGAnimatedLength(SVGElement* contextElement, const QualifiedName& attributeName, PassRefPtrWillBeRawPtr<SVGLength> initialValue)