third_party/WebKit/Source/core/svg/SVGLength.h - Issue 1544543003: Adding support of viewport units to SVG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLength.h

Issue 1544543003: Adding support of viewport units to SVG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Align with review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGLength.h

diff --git a/third_party/WebKit/Source/core/svg/SVGLength.h b/third_party/WebKit/Source/core/svg/SVGLength.h

index dc17da63b7dd8a0287e64bd0480698b836db37f5..d1463e64eb81594fad54d194dd14695296510271 100644

--- a/third_party/WebKit/Source/core/svg/SVGLength.h

+++ b/third_party/WebKit/Source/core/svg/SVGLength.h

@@ -87,7 +87,8 @@ public:

|| unitType == CSSPrimitiveValue::UnitType::Ems

|| unitType == CSSPrimitiveValue::UnitType::Exs

|| unitType == CSSPrimitiveValue::UnitType::Rems

- || unitType == CSSPrimitiveValue::UnitType::Chs;

+ || unitType == CSSPrimitiveValue::UnitType::Chs

+ || (unitType >= CSSPrimitiveValue::UnitType::ViewportWidth && unitType <= CSSPrimitiveValue::UnitType::ViewportMax);

}

inline bool isRelative() const { return isRelativeUnit(m_value->typeWithCalcResolved()); }