third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp - Issue 1544543003: Adding support of viewport units to SVG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

Issue 1544543003: Adding support of viewport units to SVG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Align with review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

index 058d7a97e54975cb0ff8920814f2fee34c6aca7a..79ca6c18242dd181dbf9c29b316bd7284ade7e51 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp

@@ -469,13 +469,10 @@ static PassRefPtrWillBeRawPtr<CSSPrimitiveValue> consumeLength(CSSParserTokenRan

case CSSPrimitiveValue::UnitType::Points:

case CSSPrimitiveValue::UnitType::Picas:

case CSSPrimitiveValue::UnitType::UserUnits:

- break;

case CSSPrimitiveValue::UnitType::ViewportWidth:

case CSSPrimitiveValue::UnitType::ViewportHeight:

case CSSPrimitiveValue::UnitType::ViewportMin:

case CSSPrimitiveValue::UnitType::ViewportMax:

- if (cssParserMode == SVGAttributeMode)

- return nullptr;

break;

default:

return nullptr;