third_party/WebKit/Source/core/svg/SVGLength.cpp - Issue 1544543003: Adding support of viewport units to SVG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLength.cpp

Issue 1544543003: Adding support of viewport units to SVG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Align with review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGLength.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGLength.cpp b/third_party/WebKit/Source/core/svg/SVGLength.cpp

index 924008740a21cea8529aa362278de5ee99d5ebba..1302a03035d5dc0eec1ebf0723b8b2b275b89bd1 100644

--- a/third_party/WebKit/Source/core/svg/SVGLength.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGLength.cpp

@@ -102,7 +102,8 @@ bool isSupportedCSSUnitType(CSSPrimitiveValue::UnitType type)

return type != CSSPrimitiveValue::UnitType::Unknown

&& (type <= CSSPrimitiveValue::UnitType::UserUnits

|| type == CSSPrimitiveValue::UnitType::Chs

- || type == CSSPrimitiveValue::UnitType::Rems);

+ || type == CSSPrimitiveValue::UnitType::Rems

+ || (type >= CSSPrimitiveValue::UnitType::ViewportWidth && type <= CSSPrimitiveValue::UnitType::ViewportMax));

}

void SVGLength::setUnitType(CSSPrimitiveValue::UnitType type)