Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1544293002: Convert Pass()→std::move() in //content (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
Avi (use Gerrit)
CC:
Aaron Boodman, abarth-chromium, avayvod+watch_chromium.org, ben+mojo_chromium.org, blink-worker-reviews_chromium.org, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, horo+watch_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, jbauman+watch_chromium.org, jkarlin+watch_chromium.org, jln+watch_chromium.org, jochen+watch_chromium.org, jsbell+serviceworker_chromium.org, kalyank, kinuko+serviceworker, kinuko+watch, maxbogue+watch_chromium.org, mcasas+watch_chromium.org, michaeln, miu+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, Peter Beverloo, piman+watch_chromium.org, plaree+watch_chromium.org, posciak+watch_chromium.org, pvalenzuela+watch_chromium.org, qsr+mojo_chromium.org, rickyz+watch_chromium.org, scheib+watch_chromium.org, serviceworker-reviews, sievers+watch_chromium.org, tim+watch_chromium.org, tzik, viettrungluu+watch_chromium.org, xjz+watch_chromium.org, yzshen+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //content BUG=557422 R=avi@chromium.org Committed: https://crrev.com/f63a125013805bf3dd72f90ec33f4d0aa0606660 Cr-Commit-Position: refs/heads/master@{#366905}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+466 lines, -358 lines) Patch
M content/app/content_main_runner.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/background_sync/background_sync_provider.cc View 8 chunks +15 lines, -9 lines 0 comments Download
M content/child/background_sync/background_sync_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/blob_storage/blob_transport_controller.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/child_discardable_shared_memory_manager.cc View 7 chunks +11 lines, -8 lines 0 comments Download
M content/child/child_gpu_memory_buffer_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/child/child_shared_bitmap_manager.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M content/child/child_thread_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/child/child_thread_impl_browsertest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/child/mojo/mojo_application.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/child/mojo/type_converters.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/navigator_connect/service_port_dispatcher_impl.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/child/navigator_connect/service_port_provider.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/child/permissions/permission_dispatcher.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/child/process_control_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/child/request_extra_data.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/child/resource_dispatcher.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/child/resource_scheduling_filter.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/child/scoped_web_callbacks.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 6 chunks +15 lines, -10 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/service_worker/service_worker_provider_context.cc View 6 chunks +12 lines, -9 lines 0 comments Download
M content/child/service_worker/web_service_worker_impl.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/child/service_worker/web_service_worker_registration_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/child/shared_memory_data_consumer_handle.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M content/child/shared_memory_data_consumer_handle_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/child/web_data_consumer_handle_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/child/web_data_consumer_handle_impl_unittest.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M content/child/web_discardable_memory_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/child/web_process_memory_dump_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/web_url_loader_impl.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M content/child/web_url_loader_impl_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/webmessageportchannel_impl.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M content/common/cc_messages.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/common/cc_messages_perftest.cc View 6 chunks +12 lines, -5 lines 0 comments Download
M content/common/cc_messages_unittest.cc View 6 chunks +9 lines, -8 lines 0 comments Download
M content/common/discardable_shared_memory_heap.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M content/common/discardable_shared_memory_heap_unittest.cc View 20 chunks +36 lines, -35 lines 0 comments Download
M content/common/font_list_pango.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/client/gl_helper_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/common/gpu/client/grcontext_for_webgraphicscontext3d.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M content/common/gpu/image_transport_surface.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M content/common/gpu/media/gpu_jpeg_decode_accelerator.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/host_discardable_shared_memory_manager.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M content/common/host_shared_bitmap_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/common/input/input_event_ack.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/common/input/input_param_traits.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/common/input/input_param_traits_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M content/common/input/synthetic_gesture_packet.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/common/input/web_input_event_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/mojo/channel_init.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M content/common/mojo/mojo_shell_connection_impl.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M content/common/mojo/service_registry_impl.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M content/common/sandbox_linux/sandbox_init_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/service_port_type_converters.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/public/browser/browser_message_filter.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/browser/download_url_parameters.h View 3 chunks +3 lines, -5 lines 0 comments Download
M content/public/browser/navigation_handle.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/public/common/service_registry.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/renderer/media_stream_api.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/test/mock_render_process_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/test/test_browser_context.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/public/test/test_download_request_handler.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/public/test/test_file_error_injector.cc View 4 chunks +16 lines, -17 lines 0 comments Download
M content/public/test/test_file_system_backend.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/public/test/test_file_system_context.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M content/public/test/test_mojo_app.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/public/test/test_utils.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 10 chunks +15 lines, -13 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_context.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_navigator_connect_service_factory.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_url_request_context_getter.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/shell/browser/shell_browser_context.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M content/shell/browser/shell_net_log.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/shell/browser/shell_url_request_context_getter.cc View 5 chunks +13 lines, -12 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/test/layouttest_support.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/test_content_client.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/test/test_navigation_url_loader.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M content/test/test_navigation_url_loader_factory.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/zygote/zygote_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/zygote/zygote_main_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
+avi for //content OWNERS review
4 years, 11 months ago (2015-12-26 18:45:29 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544293002/1
4 years, 11 months ago (2015-12-26 18:45:46 UTC) #3
Avi (use Gerrit)
lgtm stampity stamp
4 years, 11 months ago (2015-12-26 19:15:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-26 20:27:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544293002/1
4 years, 11 months ago (2015-12-26 20:36:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-26 20:43:34 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-12-26 20:44:47 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f63a125013805bf3dd72f90ec33f4d0aa0606660
Cr-Commit-Position: refs/heads/master@{#366905}

Powered by Google App Engine
This is Rietveld 408576698