content/shell/browser/layout_test/layout_test_navigator_connect_service_factory.cc - Issue 1544293002: Convert Pass()→std::move() in //content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_navigator_connect_service_factory.cc

Issue 1544293002: Convert Pass()→std::move() in //content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/browser/layout_test/layout_test_browser_context.cc ('k') | content/shell/browser/layout_test/layout_test_url_request_context_getter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_navigator_connect_service_factory.cc

diff --git a/content/shell/browser/layout_test/layout_test_navigator_connect_service_factory.cc b/content/shell/browser/layout_test/layout_test_navigator_connect_service_factory.cc

index 087ffce37d4bb23ac1a1b29e7f4e44dafe6b5051..07021de7ecc7726adf07811eed57eb7316a5b302 100644

--- a/content/shell/browser/layout_test/layout_test_navigator_connect_service_factory.cc

+++ b/content/shell/browser/layout_test/layout_test_navigator_connect_service_factory.cc

@@ -4,6 +4,8 @@

#include "content/shell/browser/layout_test/layout_test_navigator_connect_service_factory.h"

+#include <utility>

#include "base/values.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/message_port_delegate.h"

@@ -66,8 +68,9 @@ void LayoutTestNavigatorConnectServiceFactory::Service::SendMessage(

scoped_ptr<base::DictionaryValue> reply(new base::DictionaryValue);

reply->SetString("message_as_string", message.message_as_string);

reply->Set("message_as_value", message.message_as_value.DeepCopy());

- MessagePortProvider::PostMessageToPort(

- message_port_id, MessagePortMessage(reply.Pass()), sent_message_ports);

+ MessagePortProvider::PostMessageToPort(message_port_id,

+ MessagePortMessage(std::move(reply)),

+ sent_message_ports);

} else {

MessagePortProvider::PostMessageToPort(message_port_id, message,

sent_message_ports);

@@ -113,7 +116,7 @@ void LayoutTestNavigatorConnectServiceFactory::Connect(

scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue);

value->SetString("origin", client.origin.spec());

MessagePortProvider::PostMessageToPort(

- client.message_port_id, MessagePortMessage(value.Pass()),

+ client.message_port_id, MessagePortMessage(std::move(value)),

std::vector<TransferredMessagePort>());

}