Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1543963002: Refactor layout constants in preparation for adding support for Material Hybrid. (Closed)

Created:
5 years ago by Peter Kasting
Modified:
4 years, 12 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@tab_drag_height
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor layout constants in preparation for adding support for Material Hybrid. * Uses layout constants for the tab height in all cases, not just material. * Removes TAB_MAXIMUM_TITLE_WIDTH layout constant. We really just want the total maximum tab width to be the same across all modes, so compute it that way directly in tab.cc. * Adds a new GetLayoutSize() function, which currently is only used for the new tab button size. * A few other tiny cleanups. BUG=none TEST=none Committed: https://crrev.com/e3764e34b49d43a4bbeaa6a5c1d4682e0f1c6c20 Cr-Commit-Position: refs/heads/master@{#366968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -47 lines) Patch
M chrome/browser/ui/layout_constants.h View 4 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/ui/layout_constants.cc View 5 chunks +17 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/frame/glass_browser_frame_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 2 chunks +5 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 6 chunks +7 lines, -14 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Peter Kasting
5 years ago (2015-12-23 00:54:31 UTC) #3
sky
LGTM
4 years, 12 months ago (2015-12-27 23:39:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543963002/1
4 years, 12 months ago (2015-12-28 11:38:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 13:11:09 UTC) #8
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 13:12:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3764e34b49d43a4bbeaa6a5c1d4682e0f1c6c20
Cr-Commit-Position: refs/heads/master@{#366968}

Powered by Google App Engine
This is Rietveld 408576698