Compute the correct height above the tabstrip when dragging tabs.

Compute the correct height above the tabstrip when dragging tabs.

The code wanted the difference between the height in a restored windows vs. a
maximized window, but instead used the height difference between the top of the
tabstrip and the top of the new tab button.

The effect of this is that when dragging a tab out of a maximized tabstrip, the
new window is created about 5 px higher (at 100% scale) than before.

This allows moving a public constant in TabStrip to become file-scope to the .cc
file.

BUG=none
TEST=none

Committed: https://crrev.com/06c3bd3beabbd81d6036aa207e633f9bec66233a
Cr-Commit-Position: refs/heads/master@{#366964}

[Peter Kasting, 2015-12-22 23:35:56]

pkasting@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-12-27 23:42:54]

LGTM

[Peter Kasting, 2015-12-28 09:42:16]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2015-12-28 09:42:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1545863002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1545863002/1

[commit-bot: I haz the power, 2015-12-28 10:24:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-28 10:25:54]

Description was changed from

==========
Compute the correct height above the tabstrip when dragging tabs.

The code wanted the difference between the height in a restored windows vs. a
maximized window, but instead used the height difference between the top of the
tabstrip and the top of the new tab button.

The effect of this is that when dragging a tab out of a maximized tabstrip, the
new window is created about 5 px higher (at 100% scale) than before.

This allows moving a public constant in TabStrip to become file-scope to the .cc
file.

BUG=none
TEST=none
==========

to

==========
Compute the correct height above the tabstrip when dragging tabs.

The code wanted the difference between the height in a restored windows vs. a
maximized window, but instead used the height difference between the top of the
tabstrip and the top of the new tab button.

The effect of this is that when dragging a tab out of a maximized tabstrip, the
new window is created about 5 px higher (at 100% scale) than before.

This allows moving a public constant in TabStrip to become file-scope to the .cc
file.

BUG=none
TEST=none

Committed: https://crrev.com/06c3bd3beabbd81d6036aa207e633f9bec66233a
Cr-Commit-Position: refs/heads/master@{#366964}
==========

[commit-bot: I haz the power, 2015-12-28 10:25:54]

Patchset 1 (id:??) landed as
https://crrev.com/06c3bd3beabbd81d6036aa207e633f9bec66233a
Cr-Commit-Position: refs/heads/master@{#366964}