Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1541313002: Material Hybrid mode for tabstrip. (Closed)

Created:
5 years ago by Peter Kasting
Modified:
4 years, 12 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@new_layout_constants
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Material Hybrid mode for tabstrip. Mostly this involves parameterizing the tab and new tab button drawing so they can handle different desired sizes. There should be no change in material (non-hybrid) mode. This also positions the new tab button vertically based on the distance below the button instead of the distance above, since we want the gap between the button and the toolbar to remain constant even as the tab and button heights change, rather than having the button starting a fixed distance below the top of the tabs. BUG=519020 TEST=Run with --top-chrome-md=material-hybrid and check that the tabs and new tab button are larger than in material mode but still shaped correctly Committed: https://crrev.com/1854661c6e395a301949058ba495dbb5df69f77e Cr-Commit-Position: refs/heads/master@{#366971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -32 lines) Patch
M chrome/browser/ui/layout_constants.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.h View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 4 chunks +35 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 8 chunks +33 lines, -17 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Peter Kasting
5 years ago (2015-12-23 01:05:55 UTC) #2
sky
LGTM
4 years, 12 months ago (2015-12-27 23:40:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541313002/1
4 years, 12 months ago (2015-12-28 13:17:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 14:03:10 UTC) #6
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 14:04:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1854661c6e395a301949058ba495dbb5df69f77e
Cr-Commit-Position: refs/heads/master@{#366971}

Powered by Google App Engine
This is Rietveld 408576698