Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(727)

Issue 1543643002: Switch to standard integer types in courgette/. (Closed)

Created:
4 years, 7 months ago by Avi (use Gerrit)
Modified:
4 years, 7 months ago
Reviewers:
Will Harris
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in courgette/. BUG=138542 TBR=wfh@chromium.org NOPRESUBMIT=true Committed: https://crrev.com/ab98dcc986f5a27e972dad1735fe089154186cd9 Cr-Commit-Position: refs/heads/master@{#366439}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+797 lines, -664 lines) Patch
M courgette/adjustment_method.h View 1 1 chunk +1 line, -1 line 0 comments Download
M courgette/adjustment_method.cc View 12 chunks +24 lines, -22 lines 0 comments Download
M courgette/adjustment_method_2.cc View 16 chunks +32 lines, -30 lines 0 comments Download
M courgette/assembly_program.h View 5 chunks +16 lines, -12 lines 0 comments Download
M courgette/assembly_program.cc View 11 chunks +40 lines, -33 lines 0 comments Download
M courgette/bsdiff_memory_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M courgette/consecutive_range_visitor.h View 1 chunk +2 lines, -0 lines 0 comments Download
M courgette/consecutive_range_visitor_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M courgette/courgette_tool.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M courgette/crc.h View 1 chunk +3 lines, -2 lines 0 comments Download
M courgette/crc.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M courgette/difference_estimator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M courgette/difference_estimator.cc View 4 chunks +13 lines, -9 lines 0 comments Download
M courgette/disassembler.h View 3 chunks +8 lines, -6 lines 0 comments Download
M courgette/disassembler.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M courgette/disassembler_elf_32.h View 3 chunks +7 lines, -4 lines 0 comments Download
M courgette/disassembler_elf_32.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M courgette/disassembler_elf_32_arm.h View 3 chunks +18 lines, -12 lines 0 comments Download
M courgette/disassembler_elf_32_arm.cc View 22 chunks +67 lines, -61 lines 0 comments Download
M courgette/disassembler_elf_32_x86.h View 3 chunks +6 lines, -3 lines 0 comments Download
M courgette/disassembler_elf_32_x86.cc View 4 chunks +14 lines, -13 lines 0 comments Download
M courgette/disassembler_elf_32_x86_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M courgette/disassembler_win32_x64.h View 7 chunks +26 lines, -21 lines 0 comments Download
M courgette/disassembler_win32_x64.cc View 26 chunks +50 lines, -48 lines 0 comments Download
M courgette/disassembler_win32_x64_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M courgette/disassembler_win32_x86.h View 7 chunks +26 lines, -21 lines 0 comments Download
M courgette/disassembler_win32_x86.cc View 26 chunks +47 lines, -45 lines 0 comments Download
M courgette/disassembler_win32_x86_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M courgette/encode_decode_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M courgette/encoded_program.h View 5 chunks +11 lines, -8 lines 0 comments Download
M courgette/encoded_program.cc View 22 chunks +64 lines, -63 lines 0 comments Download
M courgette/encoded_program_fuzz_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M courgette/encoded_program_unittest.cc View 8 chunks +22 lines, -17 lines 0 comments Download
M courgette/ensemble.h View 2 chunks +7 lines, -5 lines 0 comments Download
M courgette/ensemble.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M courgette/ensemble_apply.cc View 5 chunks +12 lines, -9 lines 0 comments Download
M courgette/ensemble_create.cc View 1 chunk +2 lines, -1 line 0 comments Download
M courgette/image_utils.h View 3 chunks +16 lines, -15 lines 0 comments Download
M courgette/image_utils_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M courgette/label_manager.h View 2 chunks +4 lines, -1 line 0 comments Download
M courgette/label_manager.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M courgette/label_manager_unittest.cc View 4 chunks +13 lines, -18 lines 0 comments Download
M courgette/memory_allocator.h View 3 chunks +8 lines, -7 lines 0 comments Download
M courgette/memory_allocator.cc View 2 chunks +4 lines, -1 line 0 comments Download
M courgette/memory_allocator_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M courgette/memory_monitor.cc View 1 chunk +1 line, -0 lines 0 comments Download
M courgette/patch_generator_x86_32.h View 1 chunk +1 line, -1 line 0 comments Download
M courgette/patcher_x86_32.h View 2 chunks +5 lines, -2 lines 0 comments Download
M courgette/region.h View 3 chunks +9 lines, -10 lines 0 comments Download
M courgette/rel32_finder_win32_x86.h View 3 chunks +6 lines, -5 lines 0 comments Download
M courgette/rel32_finder_win32_x86.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M courgette/rel32_finder_win32_x86_unittest.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M courgette/simple_delta.cc View 1 chunk +0 lines, -1 line 0 comments Download
M courgette/streams.h View 7 chunks +16 lines, -14 lines 0 comments Download
M courgette/streams.cc View 10 chunks +31 lines, -29 lines 0 comments Download
M courgette/streams_unittest.cc View 8 chunks +15 lines, -15 lines 0 comments Download
M courgette/third_party/bsdiff.h View 2 chunks +5 lines, -4 lines 0 comments Download
M courgette/third_party/bsdiff_apply.cc View 6 chunks +17 lines, -13 lines 0 comments Download
M courgette/third_party/bsdiff_create.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M courgette/third_party/paged_array.h View 1 chunk +3 lines, -1 line 0 comments Download
M courgette/third_party/qsufsort_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M courgette/typedrva_unittest.cc View 5 chunks +15 lines, -13 lines 0 comments Download
M courgette/types_elf.h View 1 chunk +7 lines, -6 lines 0 comments Download
M courgette/types_win_pe.h View 4 chunks +14 lines, -14 lines 0 comments Download
M courgette/versioning_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543643002/1
4 years, 7 months ago (2015-12-21 17:04:46 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/110386)
4 years, 7 months ago (2015-12-21 17:10:52 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543643002/20001
4 years, 7 months ago (2015-12-21 18:05:44 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/130931)
4 years, 7 months ago (2015-12-21 18:17:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1543643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1543643002/20001
4 years, 7 months ago (2015-12-21 19:33:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2015-12-21 19:35:44 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2015-12-21 19:37:04 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab98dcc986f5a27e972dad1735fe089154186cd9
Cr-Commit-Position: refs/heads/master@{#366439}

Powered by Google App Engine
This is Rietveld 408576698