Switch to standard integer types in courgette/.

courgette/disassembler_win32_x64.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "courgette/disassembler_win32_x64.h"
 
+#include <stddef.h>
+#include <stdint.h>
+
 #include <algorithm>
 #include <string>
 #include <vector>
 
-#include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/numerics/safe_conversions.h"
 
 #include "courgette/assembly_program.h"
 #include "courgette/courgette.h"
 #include "courgette/encoded_program.h"
 
 namespace courgette {
 
 DisassemblerWin32X64::DisassemblerWin32X64(const void* start, size_t length)
@@ skipping 26 matching lines @@
 //
 bool DisassemblerWin32X64::ParseHeader() {
   if (length() < kOffsetOfFileAddressOfNewExeHeader + 4 /*size*/)
     return Bad("Too small");
 
   // Have 'MZ' magic for a DOS header?
   if (start()[0] != 'M' || start()[1] != 'Z')
     return Bad("Not MZ");
 
   // offset from DOS header to PE header is stored in DOS header.
-  uint32 offset = ReadU32(start(),
-                          kOffsetOfFileAddressOfNewExeHeader);
+  uint32_t offset = ReadU32(start(), kOffsetOfFileAddressOfNewExeHeader);
 
   if (offset >= length())
     return Bad("Bad offset to PE header");
 
-  const uint8* const pe_header = OffsetToPointer(offset);
+  const uint8_t* const pe_header = OffsetToPointer(offset);
   const size_t kMinPEHeaderSize = 4 /*signature*/ + kSizeOfCoffHeader;
   if (pe_header <= start() ||
       pe_header >= end() - kMinPEHeaderSize)
     return Bad("Bad offset to PE header");
 
   if (offset % 8 != 0)
     return Bad("Misaligned PE header");
 
   // The 'PE' header is an IMAGE_NT_HEADERS structure as defined in WINNT.H.
   // See http://msdn.microsoft.com/en-us/library/ms680336(VS.85).aspx
   //
   // The first field of the IMAGE_NT_HEADERS is the signature.
   if (!(pe_header[0] == 'P' &&
         pe_header[1] == 'E' &&
         pe_header[2] == 0 &&
         pe_header[3] == 0))
     return Bad("no PE signature");
 
   // The second field of the IMAGE_NT_HEADERS is the COFF header.
   // The COFF header is also called an IMAGE_FILE_HEADER
   //   http://msdn.microsoft.com/en-us/library/ms680313(VS.85).aspx
-  const uint8* const coff_header = pe_header + 4;
+  const uint8_t* const coff_header = pe_header + 4;
   machine_type_       = ReadU16(coff_header, 0);
   number_of_sections_ = ReadU16(coff_header, 2);
   size_of_optional_header_ = ReadU16(coff_header, 16);
 
   // The rest of the IMAGE_NT_HEADERS is the IMAGE_OPTIONAL_HEADER(32|64)
-  const uint8* const optional_header = coff_header + kSizeOfCoffHeader;
+  const uint8_t* const optional_header = coff_header + kSizeOfCoffHeader;
   optional_header_ = optional_header;
 
   if (optional_header + size_of_optional_header_ >= end())
     return Bad("optional header past end of file");
 
   // Check we can read the magic.
   if (size_of_optional_header_ < 2)
     return Bad("optional header no magic");
 
-  uint16 magic = ReadU16(optional_header, 0);
+  uint16_t magic = ReadU16(optional_header, 0);
 
   if (magic == kImageNtOptionalHdr32Magic) {
     is_PE32_plus_ = false;
     offset_of_data_directories_ =
       kOffsetOfDataDirectoryFromImageOptionalHeader32;
   } else if (magic == kImageNtOptionalHdr64Magic) {
     is_PE32_plus_ = true;
     offset_of_data_directories_ =
       kOffsetOfDataDirectoryFromImageOptionalHeader64;
   } else {
@@ skipping 56 matching lines @@
   size_t detected_length = 0;
 
   for (int i = 0;  i < number_of_sections_;  ++i) {
     const Section* section = &sections_[i];
 
     // TODO(sra): consider using the 'characteristics' field of the section
     // header to see if the section contains instructions.
     if (memcmp(section->name, ".text", 6) == 0)
       has_text_section_ = true;
 
-    uint32 section_end =
+    uint32_t section_end =
         section->file_offset_of_raw_data + section->size_of_raw_data;
     if (section_end > detected_length)
       detected_length = section_end;
   }
 
   // Pretend our in-memory copy is only as long as our detected length.
   ReduceLength(detected_length);
 
   if (is_32bit()) {
     return Bad("32 bit executables are not supported by this disassembler");
@@ skipping 32 matching lines @@
 
   size_t relocs_size = base_relocation_table_.size_;
   if (relocs_size == 0)
     return true;
 
   // The format of the base relocation table is a sequence of variable sized
   // IMAGE_BASE_RELOCATION blocks.  Search for
   //   "The format of the base relocation data is somewhat quirky"
   // at http://msdn.microsoft.com/en-us/library/ms809762.aspx
 
-  const uint8* relocs_start = RVAToPointer(base_relocation_table_.address_);
-  const uint8* relocs_end = relocs_start + relocs_size;
+  const uint8_t* relocs_start = RVAToPointer(base_relocation_table_.address_);
+  const uint8_t* relocs_end = relocs_start + relocs_size;
 
   // Make sure entire base relocation table is within the buffer.
   if (relocs_start < start() ||
       relocs_start >= end() ||
       relocs_end <= start() ||
       relocs_end > end()) {
     return Bad(".relocs outside image");
   }
 
-  const uint8* block = relocs_start;
+  const uint8_t* block = relocs_start;
 
   // Walk the variable sized blocks.
   while (block + 8 < relocs_end) {
     RVA page_rva = ReadU32(block, 0);
-    uint32 size = ReadU32(block, 4);
+    uint32_t size = ReadU32(block, 4);
     if (size < 8 ||        // Size includes header ...
         size % 4  !=  0)   // ... and is word aligned.
       return Bad("unreasonable relocs block");
 
-    const uint8* end_entries = block + size;
+    const uint8_t* end_entries = block + size;
 
     if (end_entries <= block ||
         end_entries <= start() ||
         end_entries > end())
       return Bad(".relocs block outside image");
 
     // Walk through the two-byte entries.
-    for (const uint8* p = block + 8;  p < end_entries;  p += 2) {
-      uint16 entry = ReadU16(p, 0);
+    for (const uint8_t* p = block + 8; p < end_entries; p += 2) {
+      uint16_t entry = ReadU16(p, 0);
       int type = entry >> 12;
       int offset = entry & 0xFFF;
 
       RVA rva = page_rva + offset;
       // TODO(sebmarchand): Skip the relocs that live outside of the image. See
       //   the version of this function in disassembler_win32_x86.cc.
       if (type == 10) {         // IMAGE_REL_BASED_DIR64
         relocs->push_back(rva);
       } else if (type == 0) {  // IMAGE_REL_BASED_ABSOLUTE
         // Ignore, used as padding.
       } else {
         // Does not occur in Windows x64 executables.
         return Bad("unknown type of reloc");
       }
     }
 
     block += size;
   }
 
   std::sort(relocs->begin(), relocs->end());
 
   return true;
 }
 
 const Section* DisassemblerWin32X64::RVAToSection(RVA rva) const {
   for (int i = 0; i < number_of_sections_; i++) {
     const Section* section = &sections_[i];
-    uint32 offset = rva - section->virtual_address;
+    uint32_t offset = rva - section->virtual_address;
     if (offset < section->virtual_size) {
       return section;
     }
   }
   return NULL;
 }
 
 int DisassemblerWin32X64::RVAToFileOffset(RVA rva) const {
   const Section* section = RVAToSection(rva);
   if (section) {
-    uint32 offset = rva - section->virtual_address;
+    uint32_t offset = rva - section->virtual_address;
     if (offset < section->size_of_raw_data) {
       return section->file_offset_of_raw_data + offset;
     } else {
       return kNoOffset;  // In section but not in file (e.g. uninit data).
     }
   }
 
   // Small RVA values point into the file header in the loaded image.
   // RVA 0 is the module load address which Windows uses as the module handle.
   // RVA 2 sometimes occurs, I'm not sure what it is, but it would map into the
   // DOS header.
   if (rva == 0 || rva == 2)
     return rva;
 
   NOTREACHED();
   return kNoOffset;
 }
 
-const uint8* DisassemblerWin32X64::RVAToPointer(RVA rva) const {
+const uint8_t* DisassemblerWin32X64::RVAToPointer(RVA rva) const {
   int file_offset = RVAToFileOffset(rva);
   if (file_offset == kNoOffset)
     return NULL;
   else
     return OffsetToPointer(file_offset);
 }
 
 std::string DisassemblerWin32X64::SectionName(const Section* section) {
   if (section == NULL)
     return "<none>";
   char name[9];
   memcpy(name, section->name, 8);
   name[8] = '\0';  // Ensure termination.
   return name;
 }
 
 CheckBool DisassemblerWin32X64::ParseFile(AssemblyProgram* program) {
   // Walk all the bytes in the file, whether or not in a section.
-  uint32 file_offset = 0;
+  uint32_t file_offset = 0;
   while (file_offset < length()) {
     const Section* section = FindNextSection(file_offset);
     if (section == NULL) {
       // No more sections.  There should not be extra stuff following last
       // section.
       //   ParseNonSectionFileRegion(file_offset, pe_info().length(), program);
       break;
     }
     if (file_offset < section->file_offset_of_raw_data) {
-      uint32 section_start_offset = section->file_offset_of_raw_data;
+      uint32_t section_start_offset = section->file_offset_of_raw_data;
       if(!ParseNonSectionFileRegion(file_offset, section_start_offset,
                                     program))
         return false;
 
       file_offset = section_start_offset;
     }
-    uint32 end = file_offset + section->size_of_raw_data;
+    uint32_t end = file_offset + section->size_of_raw_data;
     if (!ParseFileRegion(section, file_offset, end, program))
       return false;
     file_offset = end;
   }
 
 #if COURGETTE_HISTOGRAM_TARGETS
   HistogramTargets("abs32 relocs", abs32_target_rvas_);
   HistogramTargets("rel32 relocs", rel32_target_rvas_);
 #endif
 
   return true;
 }
 
 bool DisassemblerWin32X64::ParseAbs32Relocs() {
   abs32_locations_.clear();
   if (!ParseRelocs(&abs32_locations_))
     return false;
 
 #if COURGETTE_HISTOGRAM_TARGETS
   for (size_t i = 0;  i < abs32_locations_.size(); ++i) {
     RVA rva = abs32_locations_[i];
     // The 4 bytes at the relocation are a reference to some address.
-    uint32 target_address = Read32LittleEndian(RVAToPointer(rva));
+    uint32_t target_address = Read32LittleEndian(RVAToPointer(rva));
     ++abs32_target_rvas_[target_address - image_base()];
   }
 #endif
   return true;
 }
 
 void DisassemblerWin32X64::ParseRel32RelocsFromSections() {
-  uint32 file_offset = 0;
+  uint32_t file_offset = 0;
   while (file_offset < length()) {
     const Section* section = FindNextSection(file_offset);
     if (section == NULL)
       break;
     if (file_offset < section->file_offset_of_raw_data)
       file_offset = section->file_offset_of_raw_data;
     ParseRel32RelocsFromSection(section);
     file_offset += section->size_of_raw_data;
   }
   std::sort(rel32_locations_.begin(), rel32_locations_.end());
@@ skipping 22 matching lines @@
   VLOG(1) << "common " << common;
 #endif
 }
 
 void DisassemblerWin32X64::ParseRel32RelocsFromSection(const Section* section) {
   // TODO(sra): use characteristic.
   bool isCode = strcmp(section->name, ".text") == 0;
   if (!isCode)
     return;
 
-  uint32 start_file_offset = section->file_offset_of_raw_data;
-  uint32 end_file_offset = start_file_offset + section->size_of_raw_data;
+  uint32_t start_file_offset = section->file_offset_of_raw_data;
+  uint32_t end_file_offset = start_file_offset + section->size_of_raw_data;
   RVA relocs_start_rva = base_relocation_table().address_;
 
-  const uint8* start_pointer = OffsetToPointer(start_file_offset);
-  const uint8* end_pointer = OffsetToPointer(end_file_offset);
+  const uint8_t* start_pointer = OffsetToPointer(start_file_offset);
+  const uint8_t* end_pointer = OffsetToPointer(end_file_offset);
 
   RVA start_rva = FileOffsetToRVA(start_file_offset);
   RVA end_rva = start_rva + section->virtual_size;
 
   // Quick way to convert from Pointer to RVA within a single Section is to
   // subtract 'pointer_to_rva'.
-  const uint8* const adjust_pointer_to_rva = start_pointer - start_rva;
+  const uint8_t* const adjust_pointer_to_rva = start_pointer - start_rva;
 
   std::vector<RVA>::iterator abs32_pos = abs32_locations_.begin();
 
   // Find the rel32 relocations.
-  const uint8* p = start_pointer;
+  const uint8_t* p = start_pointer;
   while (p < end_pointer) {
     RVA current_rva = static_cast<RVA>(p - adjust_pointer_to_rva);
     if (current_rva == relocs_start_rva) {
-      uint32 relocs_size = base_relocation_table().size_;
+      uint32_t relocs_size = base_relocation_table().size_;
       if (relocs_size) {
         p += relocs_size;
         continue;
       }
     }
 
     //while (abs32_pos != abs32_locations_.end() && *abs32_pos < current_rva)
     //  ++abs32_pos;
 
     // Heuristic discovery of rel32 locations in instruction stream: are the
     // next few bytes the start of an instruction containing a rel32
     // addressing mode?
-    const uint8* rel32 = NULL;
+    const uint8_t* rel32 = NULL;
     bool is_rip_relative = false;
 
     if (p + 5 <= end_pointer) {
       if (*p == 0xE8 || *p == 0xE9)  // jmp rel32 and call rel32
         rel32 = p + 1;
     }
     if (p + 6 <= end_pointer) {
       if (*p == 0x0F && (*(p + 1) & 0xF0) == 0x80) {  // Jcc long form
         if (p[1] != 0x8A && p[1] != 0x8B)  // JPE/JPO unlikely
           rel32 = p + 2;
@@ skipping 46 matching lines @@
 #endif
         p = rel32 + 4;
         continue;
       }
     }
     p += 1;
   }
 }
 
 CheckBool DisassemblerWin32X64::ParseNonSectionFileRegion(
-    uint32 start_file_offset,
-    uint32 end_file_offset,
+    uint32_t start_file_offset,
+    uint32_t end_file_offset,
     AssemblyProgram* program) {
   if (incomplete_disassembly_)
     return true;
 
   if (end_file_offset > start_file_offset) {
     if (!program->EmitBytesInstruction(OffsetToPointer(start_file_offset),
                                        end_file_offset - start_file_offset)) {
       return false;
     }
   }
 
   return true;
 }
 
-CheckBool DisassemblerWin32X64::ParseFileRegion(
-    const Section* section,
-    uint32 start_file_offset, uint32 end_file_offset,
-    AssemblyProgram* program) {
+CheckBool DisassemblerWin32X64::ParseFileRegion(const Section* section,
+                                                uint32_t start_file_offset,
+                                                uint32_t end_file_offset,
+                                                AssemblyProgram* program) {
   RVA relocs_start_rva = base_relocation_table().address_;
 
-  const uint8* start_pointer = OffsetToPointer(start_file_offset);
-  const uint8* end_pointer = OffsetToPointer(end_file_offset);
+  const uint8_t* start_pointer = OffsetToPointer(start_file_offset);
+  const uint8_t* end_pointer = OffsetToPointer(end_file_offset);
 
   RVA start_rva = FileOffsetToRVA(start_file_offset);
   RVA end_rva = start_rva + section->virtual_size;
 
   // Quick way to convert from Pointer to RVA within a single Section is to
   // subtract 'pointer_to_rva'.
-  const uint8* const adjust_pointer_to_rva = start_pointer - start_rva;
+  const uint8_t* const adjust_pointer_to_rva = start_pointer - start_rva;
 
   std::vector<RVA>::iterator rel32_pos = rel32_locations_.begin();
   std::vector<RVA>::iterator abs32_pos = abs32_locations_.begin();
 
   if (!program->EmitOriginInstruction(start_rva))
     return false;
 
-  const uint8* p = start_pointer;
+  const uint8_t* p = start_pointer;
 
   while (p < end_pointer) {
     RVA current_rva = static_cast<RVA>(p - adjust_pointer_to_rva);
 
     // The base relocation table is usually in the .relocs section, but it could
     // actually be anywhere.  Make sure we skip it because we will regenerate it
     // during assembly.
     if (current_rva == relocs_start_rva) {
       if (!program->EmitPeRelocsInstruction())
         return false;
-      uint32 relocs_size = base_relocation_table().size_;
+      uint32_t relocs_size = base_relocation_table().size_;
       if (relocs_size) {
         p += relocs_size;
         continue;
       }
     }
 
     while (abs32_pos != abs32_locations_.end() && *abs32_pos < current_rva)
       ++abs32_pos;
 
     if (abs32_pos != abs32_locations_.end() && *abs32_pos == current_rva) {
-      uint64 target_address = Read64LittleEndian(p);
+      uint64_t target_address = Read64LittleEndian(p);
       RVA target_rva = base::checked_cast<RVA>(target_address - image_base());
       // TODO(sra): target could be Label+offset.  It is not clear how to guess
       // which it might be.  We assume offset==0.
       if (!program->EmitAbs64(program->FindOrMakeAbs32Label(target_rva)))
         return false;
       p += 8;
       continue;
     }
 
     while (rel32_pos != rel32_locations_.end() && *rel32_pos < current_rva)
@@ skipping 81 matching lines @@
   s << std::hex << rva;
   if (section) {
     s << " (";
     s << SectionName(section) << "+"
       << std::hex << (rva - section->virtual_address)
       << ")";
   }
   return s.str();
 }
 
-const Section* DisassemblerWin32X64::FindNextSection(uint32 fileOffset) const {
+const Section* DisassemblerWin32X64::FindNextSection(
+    uint32_t fileOffset) const {
   const Section* best = 0;
   for (int i = 0; i < number_of_sections_; i++) {
     const Section* section = &sections_[i];
     if (section->size_of_raw_data > 0) {  // i.e. has data in file.
       if (fileOffset <= section->file_offset_of_raw_data) {
         if (best == 0 ||
             section->file_offset_of_raw_data < best->file_offset_of_raw_data) {
           best = section;
         }
       }
     }
   }
   return best;
 }
 
-RVA DisassemblerWin32X64::FileOffsetToRVA(uint32 file_offset) const {
+RVA DisassemblerWin32X64::FileOffsetToRVA(uint32_t file_offset) const {
   for (int i = 0; i < number_of_sections_; i++) {
     const Section* section = &sections_[i];
-    uint32 offset = file_offset - section->file_offset_of_raw_data;
+    uint32_t offset = file_offset - section->file_offset_of_raw_data;
     if (offset < section->size_of_raw_data) {
       return section->virtual_address + offset;
     }
   }
   return 0;
 }
 
 bool DisassemblerWin32X64::ReadDataDirectory(
     int index,
     ImageDataDirectory* directory) {
 
   if (index < number_of_data_directories_) {
     size_t offset = index * 8 + offset_of_data_directories_;
     if (offset >= size_of_optional_header_)
       return Bad("number of data directories inconsistent");
-    const uint8* data_directory = optional_header_ + offset;
+    const uint8_t* data_directory = optional_header_ + offset;
     if (data_directory < start() ||
         data_directory + 8 >= end())
       return Bad("data directory outside image");
     RVA rva = ReadU32(data_directory, 0);
     size_t size  = ReadU32(data_directory, 4);
     if (size > size_of_image_)
       return Bad("data directory size too big");
 
     // TODO(sra): validate RVA.
     directory->address_ = rva;
-    directory->size_ = static_cast<uint32>(size);
+    directory->size_ = static_cast<uint32_t>(size);
     return true;
   } else {
     directory->address_ = 0;
     directory->size_ = 0;
     return true;
   }
 }
 
 }  // namespace courgette