Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 15427003: Remove 100 superfluous includes from core/rendering/svg (Closed)

Created:
7 years, 7 months ago by pdr.
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Visibility:
Public.

Description

Remove 100 superfluous includes from core/rendering/svg This patch removes 100 #include statements that were found to be unnecessary. An experimental script was used to find these includes; if this patch proves successful I will post a patch with the script and run it over larger parts of the codebase. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150643

Patch Set 1 #

Patch Set 2 : Add back RenderView.h include to RenderSVGResourceContainer.cpp, broke rel compiles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -110 lines) Patch
M Source/core/rendering/svg/RenderSVGBlock.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGBlock.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGContainer.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGEllipse.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGEllipse.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGForeignObject.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGForeignObject.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGGradientStop.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGHiddenContainer.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInline.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInline.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInlineText.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGInlineText.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGPath.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRect.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResource.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResource.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.h View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
rs=me LGTM
7 years, 7 months ago (2013-05-20 03:10:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/15427003/2001
7 years, 7 months ago (2013-05-20 03:15:18 UTC) #2
commit-bot: I haz the power
7 years, 7 months ago (2013-05-20 03:59:51 UTC) #3
Message was sent while issue was closed.
Change committed as 150643

Powered by Google App Engine
This is Rietveld 408576698