Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1541943002: Delete media::Interfaces::ServiceFactory. (Closed)

Created:
4 years, 12 months ago by alokp
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, feature-media-reviews_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete media::Interfaces::ServiceFactory. ServiceFactory was used to bundle the services vended by mojo:media for each RenderFrame. The bundle shares a CDM context, which is used to verify that a renderer service in a bundle cannot use a CDM from another RenderFrame. The same can be accomplished by bundling the services on the media service side using incoming application URL. This new scheme is preferable because CDM restriction is transparent to the clients. The clients do not need to remember to carry around and use the same service factory to acquire all media services. It is automatically handled on the service side.

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : add service bundle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -203 lines) Patch
M components/html_viewer/media_factory.h View 3 chunks +2 lines, -3 lines 0 comments Download
M components/html_viewer/media_factory.cc View 3 chunks +8 lines, -11 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 3 chunks +2 lines, -9 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 3 chunks +6 lines, -21 lines 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D media/mojo/interfaces/service_factory.mojom View 1 chunk +0 lines, -18 lines 0 comments Download
M media/mojo/services/mojo_cdm_factory.h View 2 chunks +6 lines, -6 lines 0 comments Download
M media/mojo/services/mojo_cdm_factory.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.h View 1 2 3 chunks +2 lines, -9 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.cc View 1 2 1 chunk +3 lines, -8 lines 0 comments Download
M media/mojo/services/mojo_media_application.h View 2 chunks +3 lines, -12 lines 0 comments Download
M media/mojo/services/mojo_media_application.cc View 3 chunks +6 lines, -19 lines 0 comments Download
M media/mojo/services/mojo_renderer_factory.h View 1 2 chunks +6 lines, -8 lines 0 comments Download
M media/mojo/services/mojo_renderer_factory.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 1 2 3 chunks +2 lines, -10 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M media/mojo/services/service_factory_impl.h View 1 2 2 chunks +30 lines, -25 lines 0 comments Download
M media/mojo/services/service_factory_impl.cc View 1 2 4 chunks +78 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (4 generated)
alokp
Patchset #2 (id:20001) has been deleted
4 years, 12 months ago (2015-12-21 21:23:10 UTC) #1
alokp
Description was changed from ========== Delete media::Interfaces::ServiceFactory. ========== to ========== Delete media::Interfaces::ServiceFactory. ServiceFactory was used ...
4 years, 12 months ago (2015-12-21 23:36:53 UTC) #2
alokp
alokp@chromium.org changed reviewers: + rockot@chromium.org, xhwang@chromium.org
4 years, 12 months ago (2015-12-21 23:36:53 UTC) #3
alokp
4 years, 12 months ago (2015-12-21 23:37:19 UTC) #4 
Description was changed from

==========
Delete media::Interfaces::ServiceFactory.

ServiceFactory was used to bundle the services vended by
mojo:media for each RenderFrame. The bundle shares a CDM
context, which is used to verify that a renderer service in
a bundle cannot use a CDM from another RenderFrame.
    
The same can be accomplished by bundling the services on the media service side
using incoming application URL. This new scheme is preferable because CDM
restriction is transparent to the clients. The clients do not need to remember
to carry around and use the same service factory to acquire all media services.
It is automatically handled on the service side.
==========

to

==========
Delete media::Interfaces::ServiceFactory.

ServiceFactory was used to bundle the services vended by
mojo:media for each RenderFrame. The bundle shares a CDM
context, which is used to verify that a renderer service in
a bundle cannot use a CDM from another RenderFrame.
    
The same can be accomplished by bundling the services on
the media service side using incoming application URL. This
new scheme is preferable because CDM restriction is
transparent to the clients. The clients do not need to
remember to carry around and use the same service factory
to acquire all media services. It is automatically handled
on the service side.
==========

Powered by Google App Engine
This is Rietveld 408576698