Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: components/html_viewer/media_factory.cc

Issue 1541943002: Delete media::Interfaces::ServiceFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add service bundle Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/html_viewer/media_factory.h ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/html_viewer/media_factory.cc
diff --git a/components/html_viewer/media_factory.cc b/components/html_viewer/media_factory.cc
index cec7ae8799ee76e39b24f8ff12611f4034d55299..98890d523fe6e3ab63d55e86f0dfa47f026bb0d2 100644
--- a/components/html_viewer/media_factory.cc
+++ b/components/html_viewer/media_factory.cc
@@ -89,7 +89,7 @@ blink::WebMediaPlayer* MediaFactory::CreateMediaPlayer(
if (enable_mojo_media_renderer_) {
media_renderer_factory.reset(
- new media::MojoRendererFactory(GetMediaServiceFactory()));
+ new media::MojoRendererFactory(GetMediaServiceProvider()));
} else {
media_renderer_factory.reset(
new media::DefaultRendererFactory(media_log,
@@ -125,18 +125,15 @@ blink::WebEncryptedMediaClient* MediaFactory::GetEncryptedMediaClient() {
return web_encrypted_media_client_.get();
}
-media::interfaces::ServiceFactory* MediaFactory::GetMediaServiceFactory() {
- if (!media_service_factory_) {
- mojo::ServiceProviderPtr service_provider;
+mojo::ServiceProvider* MediaFactory::GetMediaServiceProvider() {
+ if (!media_service_provider_) {
mojo::URLRequestPtr request(mojo::URLRequest::New());
request->url = mojo::String::From("mojo:media");
- shell_->ConnectToApplication(request.Pass(), GetProxy(&service_provider),
- nullptr, nullptr,
- base::Bind(&OnGotContentHandlerID));
- mojo::ConnectToService(service_provider.get(), &media_service_factory_);
+ shell_->ConnectToApplication(std::move(request),
+ GetProxy(&media_service_provider_), nullptr,
+ nullptr, base::Bind(&OnGotContentHandlerID));
}
-
- return media_service_factory_.get();
+ return media_service_provider_.get();
}
media::MediaPermission* MediaFactory::GetMediaPermission() {
@@ -152,7 +149,7 @@ media::MediaPermission* MediaFactory::GetMediaPermission() {
media::CdmFactory* MediaFactory::GetCdmFactory() {
if (!cdm_factory_) {
if (enable_mojo_media_renderer_)
- cdm_factory_.reset(new media::MojoCdmFactory(GetMediaServiceFactory()));
+ cdm_factory_.reset(new media::MojoCdmFactory(GetMediaServiceProvider()));
else
cdm_factory_.reset(new media::DefaultCdmFactory());
}
« no previous file with comments | « components/html_viewer/media_factory.h ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698