Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1541403002: [field type tracking] Fix handling of cleared WeakCells. (Closed)

Created:
5 years ago by Igor Sheludko
Modified:
5 years ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[field type tracking] Fix handling of cleared WeakCells. Previous CL (https://codereview.chromium.org/1522413002) has a typo. BUG=chromium:571402, chromium:514080, chromium:527994, v8:4325 LOG=N Committed: https://crrev.com/5ca478a5563b01dfc4b9eebacd2757f15cb123fa Cr-Commit-Position: refs/heads/master@{#33031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ulan
lgtm
5 years ago (2015-12-23 15:52:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541403002/1
5 years ago (2015-12-23 15:53:42 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-23 16:15:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541403002/1
5 years ago (2015-12-23 17:07:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-23 17:09:06 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-23 17:09:43 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5ca478a5563b01dfc4b9eebacd2757f15cb123fa
Cr-Commit-Position: refs/heads/master@{#33031}

Powered by Google App Engine
This is Rietveld 408576698