Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: src/objects.cc

Issue 1541403002: [field type tracking] Fix handling of cleared WeakCells. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index a29f48de081ebdc405437e567206c91773cafad3..004a4bd6020224b3756b8d4c15575f67ccb22e14 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -3833,8 +3833,8 @@ MaybeHandle<Map> Map::TryUpdate(Handle<Map> old_map) {
case DATA: {
HeapType* new_type = new_descriptors->GetFieldType(i);
// Cleared field types need special treatment. They represent lost
- // knowledge, so we must first generalize the old_type to "Any".
- if (!FieldTypeIsCleared(new_details.representation(), new_type)) {
+ // knowledge, so we must first generalize the new_type to "Any".
+ if (FieldTypeIsCleared(new_details.representation(), new_type)) {
return MaybeHandle<Map>();
}
PropertyType old_property_type = old_details.type();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698