Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1522413002: [field type tracking] Fix handling of cleared WeakCells. (Closed)

Created:
5 years ago by Igor Sheludko
Modified:
5 years ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[field type tracking] Fix handling of cleared WeakCells. BUG=chromium:514080, chromium:527994, v8:4325 LOG=N Committed: https://crrev.com/debf2adcdfcdbb6402fa97d225a29a28a0dbc665 Cr-Commit-Position: refs/heads/master@{#32871}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M src/objects.cc View 1 4 chunks +10 lines, -4 lines 0 comments Download
M src/objects-debug.cc View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522413002/1
5 years ago (2015-12-15 14:15:46 UTC) #2
Igor Sheludko
PTAL
5 years ago (2015-12-15 14:15:56 UTC) #4
Jakob Kummerow
lgtm
5 years ago (2015-12-15 14:31:23 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/13117)
5 years ago (2015-12-15 14:46:00 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522413002/20001
5 years ago (2015-12-15 14:46:22 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-15 15:05:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522413002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522413002/20001
5 years ago (2015-12-15 15:42:41 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-15 15:43:49 UTC) #15
commit-bot: I haz the power
5 years ago (2015-12-15 15:44:00 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/debf2adcdfcdbb6402fa97d225a29a28a0dbc665
Cr-Commit-Position: refs/heads/master@{#32871}

Powered by Google App Engine
This is Rietveld 408576698