Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1540693002: Get rid of a few CPDF_Object Create() methods and just use new instead. (Closed)

Created:
5 years ago by Lei Zhang
Modified:
5 years ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get rid of a few CPDF_Object Create() methods and just use new instead. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d866ab0b44a571c884fdd8ba5a5319adaf607559

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -169 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 1 9 chunks +15 lines, -45 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 1 2 chunks +10 lines, -9 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 1 4 chunks +23 lines, -27 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 10 chunks +16 lines, -16 lines 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 4 chunks +4 lines, -13 lines 0 comments Download
M core/src/fpdfdoc/doc_basic.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 1 2 chunks +3 lines, -14 lines 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 1 5 chunks +6 lines, -18 lines 0 comments Download
M core/src/fpdfdoc/doc_utils.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 1 4 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
5 years ago (2015-12-18 23:47:01 UTC) #2
Oliver Chang
lgtm
5 years ago (2015-12-18 23:55:43 UTC) #3
Lei Zhang
It turned out getting rid of the rest wasn't that much more work. So PTAL ...
5 years ago (2015-12-19 00:02:33 UTC) #4
Oliver Chang
lgtm again
5 years ago (2015-12-19 00:08:52 UTC) #5
Lei Zhang
5 years ago (2015-12-19 00:26:52 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
d866ab0b44a571c884fdd8ba5a5319adaf607559 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698