core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp - Issue 1540693002: Get rid of a few CPDF_Object Create() methods and just use new instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp

Issue 1540693002: Get rid of a few CPDF_Object Create() methods and just use new instead. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp

diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp

index 5810da572bde7bb1df84347d8676abcc3c4cdebb..f00cf5f8f50e69ab0c604d141bcb8a5f003e27b3 100644

--- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp

+++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp

@@ -106,7 +106,7 @@ void CPDF_PageContentGenerate::ProcessForm(CFX_ByteTextBuf& buf,

return;

}

CPDF_Stream* pStream = new CPDF_Stream(NULL, 0, NULL);

- CPDF_Dictionary* pFormDict = CPDF_Dictionary::Create();

+ CPDF_Dictionary* pFormDict = new CPDF_Dictionary;

pFormDict->SetAtName("Type", "XObject");

pFormDict->SetAtName("Subtype", "Form");

CFX_FloatRect bbox = m_pPage->GetPageBBox();

« no previous file with comments | « core/include/fpdfapi/fpdf_objects.h ('k') | core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp » ('j') | no next file with comments »