Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp

Issue 1540693002: Get rid of a few CPDF_Object Create() methods and just use new instead. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « core/include/fpdfapi/fpdf_objects.h ('k') | core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "core/include/fpdfapi/fpdf_module.h" 7 #include "core/include/fpdfapi/fpdf_module.h"
8 #include "core/include/fpdfapi/fpdf_page.h" 8 #include "core/include/fpdfapi/fpdf_page.h"
9 #include "core/include/fpdfapi/fpdf_serial.h" 9 #include "core/include/fpdfapi/fpdf_serial.h"
10 #include "core/src/fpdfapi/fpdf_page/pageint.h" 10 #include "core/src/fpdfapi/fpdf_page/pageint.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 } 99 }
100 } 100 }
101 void CPDF_PageContentGenerate::ProcessForm(CFX_ByteTextBuf& buf, 101 void CPDF_PageContentGenerate::ProcessForm(CFX_ByteTextBuf& buf,
102 const uint8_t* data, 102 const uint8_t* data,
103 FX_DWORD size, 103 FX_DWORD size,
104 CFX_Matrix& matrix) { 104 CFX_Matrix& matrix) {
105 if (!data || !size) { 105 if (!data || !size) {
106 return; 106 return;
107 } 107 }
108 CPDF_Stream* pStream = new CPDF_Stream(NULL, 0, NULL); 108 CPDF_Stream* pStream = new CPDF_Stream(NULL, 0, NULL);
109 CPDF_Dictionary* pFormDict = CPDF_Dictionary::Create(); 109 CPDF_Dictionary* pFormDict = new CPDF_Dictionary;
110 pFormDict->SetAtName("Type", "XObject"); 110 pFormDict->SetAtName("Type", "XObject");
111 pFormDict->SetAtName("Subtype", "Form"); 111 pFormDict->SetAtName("Subtype", "Form");
112 CFX_FloatRect bbox = m_pPage->GetPageBBox(); 112 CFX_FloatRect bbox = m_pPage->GetPageBBox();
113 matrix.TransformRect(bbox); 113 matrix.TransformRect(bbox);
114 pFormDict->SetAtRect("BBox", bbox); 114 pFormDict->SetAtRect("BBox", bbox);
115 pStream->InitStream((uint8_t*)data, size, pFormDict); 115 pStream->InitStream((uint8_t*)data, size, pFormDict);
116 buf << "q " << matrix << " cm "; 116 buf << "q " << matrix << " cm ";
117 CFX_ByteString name = RealizeResource(pStream, "XObject"); 117 CFX_ByteString name = RealizeResource(pStream, "XObject");
118 buf << "/" << PDF_NameEncode(name) << " Do Q\n"; 118 buf << "/" << PDF_NameEncode(name) << " Do Q\n";
119 } 119 }
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 CPDF_StreamAcc contentStream; 156 CPDF_StreamAcc contentStream;
157 contentStream.LoadAllData(pStream); 157 contentStream.LoadAllData(pStream);
158 ProcessForm(buf, contentStream.GetData(), contentStream.GetSize(), matrix); 158 ProcessForm(buf, contentStream.GetData(), contentStream.GetSize(), matrix);
159 } 159 }
160 CPDF_Stream* pStream = new CPDF_Stream(NULL, 0, NULL); 160 CPDF_Stream* pStream = new CPDF_Stream(NULL, 0, NULL);
161 pStream->SetData(buf.GetBuffer(), buf.GetLength(), FALSE, FALSE); 161 pStream->SetData(buf.GetBuffer(), buf.GetLength(), FALSE, FALSE);
162 m_pDocument->AddIndirectObject(pStream); 162 m_pDocument->AddIndirectObject(pStream);
163 m_pPage->m_pFormDict->SetAtReference("Contents", m_pDocument, 163 m_pPage->m_pFormDict->SetAtReference("Contents", m_pDocument,
164 pStream->GetObjNum()); 164 pStream->GetObjNum());
165 } 165 }
OLDNEW
« no previous file with comments | « core/include/fpdfapi/fpdf_objects.h ('k') | core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698