Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1540333002: Allow Window.open to return null in dart2js (Closed)

Created:
5 years ago by Alan Knight
Modified:
5 years ago
Reviewers:
sra1
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review fixes #

Patch Set 3 : ... and regenerate aftef fixing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Alan Knight
5 years ago (2015-12-21 19:24:27 UTC) #2
sra1
lgtm https://codereview.chromium.org/1540333002/diff/1/tools/dom/templates/html/impl/impl_Window.darttemplate File tools/dom/templates/html/impl/impl_Window.darttemplate (right): https://codereview.chromium.org/1540333002/diff/1/tools/dom/templates/html/impl/impl_Window.darttemplate#newcode50 tools/dom/templates/html/impl/impl_Window.darttemplate:50: WindowBase _open2(url, name) => JS('Window|Null', '#.open(#,#)', this, url, ...
5 years ago (2015-12-21 21:25:19 UTC) #3
Alan Knight
https://codereview.chromium.org/1540333002/diff/1/tools/dom/templates/html/impl/impl_Window.darttemplate File tools/dom/templates/html/impl/impl_Window.darttemplate (right): https://codereview.chromium.org/1540333002/diff/1/tools/dom/templates/html/impl/impl_Window.darttemplate#newcode50 tools/dom/templates/html/impl/impl_Window.darttemplate:50: WindowBase _open2(url, name) => JS('Window|Null', '#.open(#,#)', this, url, name); ...
5 years ago (2015-12-21 21:27:09 UTC) #4
Alan Knight
5 years ago (2015-12-21 21:32:34 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
ced1e5d1e7475e514153cb2b5df4634b4cdf17be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698