sdk/lib/html/dart2js/html_dart2js.dart - Issue 1540333002: Allow Window.open to return null in dart2js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 1540333002: Allow Window.open to return null in dart2js (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: ... and regenerate aftef fixing Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/dart2js/html_dart2js.dart

diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart

index 8acae64c58bef68af8114e88304584654eec0e45..883ae88ff1caaa01e4fb046abc37f08ea4f1ee66 100644

--- a/sdk/lib/html/dart2js/html_dart2js.dart

+++ b/sdk/lib/html/dart2js/html_dart2js.dart

@@ -31962,10 +31962,11 @@ class Window extends EventTarget implements WindowEventHandlers, WindowBase, Glo

Document get document => JS('Document', '#.document', this);

- WindowBase _open2(url, name) => JS('Window', '#.open(#,#)', this, url, name);

+ WindowBase _open2(url, name) =>

+ JS('Window|Null', '#.open(#,#)', this, url, name);

WindowBase _open3(url, name, options) =>

- JS('Window', '#.open(#,#,#)', this, url, name, options);

+ JS('Window|Null', '#.open(#,#,#)', this, url, name, options);

/**

* Opens a new window.

« no previous file with comments | « no previous file | tools/dom/templates/html/impl/impl_Window.darttemplate » ('j') | no next file with comments »